linux-kernel - Re: [PATCH net-next v2] dpll: zl3073x: Allow to use custom phase measure averaging factor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250916152506.256ea653@kernel.org>
Date: Tue, 16 Sep 2025 15:25:06 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Ivan Vecera <ivecera@...hat.com>
Cc: netdev@...r.kernel.org, Przemek Kitszel <przemyslaw.kitszel@...el.com>,
 Prathosh Satish <Prathosh.Satish@...rochip.com>, Jiri Pirko
 <jiri@...nulli.us>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Simon Horman
 <horms@...nel.org>, Jonathan Corbet <corbet@....net>,
 linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org, Arkadiusz
 Kubalewski <arkadiusz.kubalewski@...el.com>
Subject: Re: [PATCH net-next v2] dpll: zl3073x: Allow to use custom phase
 measure averaging factor

On Tue, 16 Sep 2025 20:16:57 +0200 Ivan Vecera wrote:
> >> Add devlink device parameter phase_offset_avg_factor to allow a user
> >> set tune the averaging factor via devlink interface.  
> >
> >Is averaging phase offset normal for DPLL devices?  
> 
> I don't know... I expect that DPLL chips support phase offset
> measurement but probably implementation specific.

Ack, I was hoping Arkadiusz and Vadim could comment what their DPLL
devices do.

> >If it is we should probably add this to the official API.  
> 
> The problem in case of this Microchip DPLL devices is that this
> parameter is per ASIC. It is common for all DPLL channels
> (devices) inside the chip. That's why I chose devlink.
> 
> >If it isn't we should probably default to smallest possible history?  
> 
> Do you mean the default value?

Yes, but let's wait for others to chime in.