lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <202509161304.mQnxOxhS-lkp@intel.com>
Date: Tue, 16 Sep 2025 13:55:38 +0800
From: kernel test robot <lkp@...el.com>
To: Chunyan Zhang <zhangchunyan@...as.ac.cn>,
	linux-riscv@...ts.infradead.org, linux-fsdevel@...r.kernel.org,
	linux-mm@...ck.org, linux-kernel@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev, Paul Walmsley <paul.walmsley@...ive.com>,
	Palmer Dabbelt <palmer@...belt.com>,
	Albert Ou <aou@...s.berkeley.edu>, Alexandre Ghiti <alex@...ti.fr>,
	Deepak Gupta <debug@...osinc.com>,
	Ved Shanbhogue <ved@...osinc.com>,
	Alexander Viro <viro@...iv.linux.org.uk>,
	Christian Brauner <brauner@...nel.org>, Jan Kara <jack@...e.cz>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linux Memory Management List <linux-mm@...ck.org>,
	Peter Xu <peterx@...hat.com>, Arnd Bergmann <arnd@...db.de>,
	David Hildenbrand <david@...hat.com>,
	Lorenzo Stoakes <lorenzo.stoakes@...cle.com>,
	"Liam R . Howlett" <Liam.Howlett@...cle.com>,
	Vlastimil Babka <vbabka@...e.cz>, Mike Rapoport <rppt@...nel.org>,
	Suren Baghdasaryan <surenb@...gle.com>,
	Michal Hocko <mhocko@...e.com>,
	Axel Rasmussen <axelrasmussen@...gle.com>,
	Yuanchu Xie <yuanchu@...gle.com>,
	Chunyan Zhang <zhang.lyra@...il.com>
Subject: Re: [PATCH V12 2/5] mm: userfaultfd: Add pgtable_supports_uffd_wp()

Hi Chunyan,

kernel test robot noticed the following build errors:

[auto build test ERROR on brauner-vfs/vfs.all]
[also build test ERROR on kees/for-next/execve linus/master v6.17-rc6]
[cannot apply to akpm-mm/mm-everything next-20250915]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Chunyan-Zhang/mm-softdirty-Add-pgtable_supports_soft_dirty/20250915-181826
base:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git vfs.all
patch link:    https://lore.kernel.org/r/20250915101343.1449546-3-zhangchunyan%40iscas.ac.cn
patch subject: [PATCH V12 2/5] mm: userfaultfd: Add pgtable_supports_uffd_wp()
config: riscv-randconfig-002-20250916 (https://download.01.org/0day-ci/archive/20250916/202509161304.mQnxOxhS-lkp@intel.com/config)
compiler: riscv32-linux-gcc (GCC) 10.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250916/202509161304.mQnxOxhS-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202509161304.mQnxOxhS-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from include/linux/mm_inline.h:10,
                    from mm/internal.h:13,
                    from mm/page_frag_cache.c:21:
   include/linux/userfaultfd_k.h: In function 'pte_marker_entry_uffd_wp':
>> include/linux/userfaultfd_k.h:441:9: error: implicit declaration of function 'is_pte_marker_entry' [-Werror=implicit-function-declaration]
     441 |  return is_pte_marker_entry(entry) &&
         |         ^~~~~~~~~~~~~~~~~~~
>> include/linux/userfaultfd_k.h:442:10: error: implicit declaration of function 'pte_marker_get' [-Werror=implicit-function-declaration]
     442 |         (pte_marker_get(entry) & PTE_MARKER_UFFD_WP);
         |          ^~~~~~~~~~~~~~
>> include/linux/userfaultfd_k.h:442:34: error: 'PTE_MARKER_UFFD_WP' undeclared (first use in this function)
     442 |         (pte_marker_get(entry) & PTE_MARKER_UFFD_WP);
         |                                  ^~~~~~~~~~~~~~~~~~
   include/linux/userfaultfd_k.h:442:34: note: each undeclared identifier is reported only once for each function it appears in
   include/linux/userfaultfd_k.h: In function 'pte_marker_uffd_wp':
>> include/linux/userfaultfd_k.h:452:7: error: implicit declaration of function 'is_swap_pte'; did you mean 'is_swap_pmd'? [-Werror=implicit-function-declaration]
     452 |  if (!is_swap_pte(pte))
         |       ^~~~~~~~~~~
         |       is_swap_pmd
>> include/linux/userfaultfd_k.h:455:10: error: implicit declaration of function 'pte_to_swp_entry' [-Werror=implicit-function-declaration]
     455 |  entry = pte_to_swp_entry(pte);
         |          ^~~~~~~~~~~~~~~~
>> include/linux/userfaultfd_k.h:455:10: error: incompatible types when assigning to type 'swp_entry_t' from type 'int'
   In file included from include/linux/mm_inline.h:11,
                    from mm/internal.h:13,
                    from mm/page_frag_cache.c:21:
   include/linux/swapops.h: At top level:
>> include/linux/swapops.h:124:19: error: static declaration of 'is_swap_pte' follows non-static declaration
     124 | static inline int is_swap_pte(pte_t pte)
         |                   ^~~~~~~~~~~
   In file included from include/linux/mm_inline.h:10,
                    from mm/internal.h:13,
                    from mm/page_frag_cache.c:21:
   include/linux/userfaultfd_k.h:452:7: note: previous implicit declaration of 'is_swap_pte' was here
     452 |  if (!is_swap_pte(pte))
         |       ^~~~~~~~~~~
   In file included from include/linux/mm_inline.h:11,
                    from mm/internal.h:13,
                    from mm/page_frag_cache.c:21:
>> include/linux/swapops.h:133:27: error: conflicting types for 'pte_to_swp_entry'
     133 | static inline swp_entry_t pte_to_swp_entry(pte_t pte)
         |                           ^~~~~~~~~~~~~~~~
   In file included from include/linux/mm_inline.h:10,
                    from mm/internal.h:13,
                    from mm/page_frag_cache.c:21:
   include/linux/userfaultfd_k.h:455:10: note: previous implicit declaration of 'pte_to_swp_entry' was here
     455 |  entry = pte_to_swp_entry(pte);
         |          ^~~~~~~~~~~~~~~~
   In file included from include/linux/mm_inline.h:11,
                    from mm/internal.h:13,
                    from mm/page_frag_cache.c:21:
>> include/linux/swapops.h:429:20: error: conflicting types for 'is_pte_marker_entry'
     429 | static inline bool is_pte_marker_entry(swp_entry_t entry)
         |                    ^~~~~~~~~~~~~~~~~~~
   In file included from include/linux/mm_inline.h:10,
                    from mm/internal.h:13,
                    from mm/page_frag_cache.c:21:
   include/linux/userfaultfd_k.h:441:9: note: previous implicit declaration of 'is_pte_marker_entry' was here
     441 |  return is_pte_marker_entry(entry) &&
         |         ^~~~~~~~~~~~~~~~~~~
   In file included from include/linux/mm_inline.h:11,
                    from mm/internal.h:13,
                    from mm/page_frag_cache.c:21:
>> include/linux/swapops.h:434:26: error: conflicting types for 'pte_marker_get'
     434 | static inline pte_marker pte_marker_get(swp_entry_t entry)
         |                          ^~~~~~~~~~~~~~
   In file included from include/linux/mm_inline.h:10,
                    from mm/internal.h:13,
                    from mm/page_frag_cache.c:21:
   include/linux/userfaultfd_k.h:442:10: note: previous implicit declaration of 'pte_marker_get' was here
     442 |         (pte_marker_get(entry) & PTE_MARKER_UFFD_WP);
         |          ^~~~~~~~~~~~~~
   cc1: some warnings being treated as errors
--
   In file included from include/linux/mm_inline.h:10,
                    from mm/mremap.c:12:
   include/linux/userfaultfd_k.h: In function 'pte_marker_entry_uffd_wp':
>> include/linux/userfaultfd_k.h:441:9: error: implicit declaration of function 'is_pte_marker_entry' [-Werror=implicit-function-declaration]
     441 |  return is_pte_marker_entry(entry) &&
         |         ^~~~~~~~~~~~~~~~~~~
>> include/linux/userfaultfd_k.h:442:10: error: implicit declaration of function 'pte_marker_get' [-Werror=implicit-function-declaration]
     442 |         (pte_marker_get(entry) & PTE_MARKER_UFFD_WP);
         |          ^~~~~~~~~~~~~~
>> include/linux/userfaultfd_k.h:442:34: error: 'PTE_MARKER_UFFD_WP' undeclared (first use in this function)
     442 |         (pte_marker_get(entry) & PTE_MARKER_UFFD_WP);
         |                                  ^~~~~~~~~~~~~~~~~~
   include/linux/userfaultfd_k.h:442:34: note: each undeclared identifier is reported only once for each function it appears in
   include/linux/userfaultfd_k.h: In function 'pte_marker_uffd_wp':
>> include/linux/userfaultfd_k.h:452:7: error: implicit declaration of function 'is_swap_pte'; did you mean 'is_swap_pmd'? [-Werror=implicit-function-declaration]
     452 |  if (!is_swap_pte(pte))
         |       ^~~~~~~~~~~
         |       is_swap_pmd
>> include/linux/userfaultfd_k.h:455:10: error: implicit declaration of function 'pte_to_swp_entry' [-Werror=implicit-function-declaration]
     455 |  entry = pte_to_swp_entry(pte);
         |          ^~~~~~~~~~~~~~~~
>> include/linux/userfaultfd_k.h:455:10: error: incompatible types when assigning to type 'swp_entry_t' from type 'int'
   In file included from include/linux/mm_inline.h:11,
                    from mm/mremap.c:12:
   include/linux/swapops.h: At top level:
>> include/linux/swapops.h:124:19: error: static declaration of 'is_swap_pte' follows non-static declaration
     124 | static inline int is_swap_pte(pte_t pte)
         |                   ^~~~~~~~~~~
   In file included from include/linux/mm_inline.h:10,
                    from mm/mremap.c:12:
   include/linux/userfaultfd_k.h:452:7: note: previous implicit declaration of 'is_swap_pte' was here
     452 |  if (!is_swap_pte(pte))
         |       ^~~~~~~~~~~
   In file included from include/linux/mm_inline.h:11,
                    from mm/mremap.c:12:
>> include/linux/swapops.h:133:27: error: conflicting types for 'pte_to_swp_entry'
     133 | static inline swp_entry_t pte_to_swp_entry(pte_t pte)
         |                           ^~~~~~~~~~~~~~~~
   In file included from include/linux/mm_inline.h:10,
                    from mm/mremap.c:12:
   include/linux/userfaultfd_k.h:455:10: note: previous implicit declaration of 'pte_to_swp_entry' was here
     455 |  entry = pte_to_swp_entry(pte);
         |          ^~~~~~~~~~~~~~~~
   In file included from include/linux/mm_inline.h:11,
                    from mm/mremap.c:12:
>> include/linux/swapops.h:429:20: error: conflicting types for 'is_pte_marker_entry'
     429 | static inline bool is_pte_marker_entry(swp_entry_t entry)
         |                    ^~~~~~~~~~~~~~~~~~~
   In file included from include/linux/mm_inline.h:10,
                    from mm/mremap.c:12:
   include/linux/userfaultfd_k.h:441:9: note: previous implicit declaration of 'is_pte_marker_entry' was here
     441 |  return is_pte_marker_entry(entry) &&
         |         ^~~~~~~~~~~~~~~~~~~
   In file included from include/linux/mm_inline.h:11,
                    from mm/mremap.c:12:
>> include/linux/swapops.h:434:26: error: conflicting types for 'pte_marker_get'
     434 | static inline pte_marker pte_marker_get(swp_entry_t entry)
         |                          ^~~~~~~~~~~~~~
   In file included from include/linux/mm_inline.h:10,
                    from mm/mremap.c:12:
   include/linux/userfaultfd_k.h:442:10: note: previous implicit declaration of 'pte_marker_get' was here
     442 |         (pte_marker_get(entry) & PTE_MARKER_UFFD_WP);
         |          ^~~~~~~~~~~~~~
   In file included from include/linux/mm_inline.h:10,
                    from mm/mremap.c:12:
   include/linux/userfaultfd_k.h: In function 'pte_marker_entry_uffd_wp':
   include/linux/userfaultfd_k.h:443:1: warning: control reaches end of non-void function [-Wreturn-type]
     443 | }
         | ^
   cc1: some warnings being treated as errors


vim +/is_pte_marker_entry +441 include/linux/userfaultfd_k.h

2bad466cc9d9b4c Peter Xu      2023-03-09  435  
1db9dbc2ef05205 Peter Xu      2022-05-12  436  static inline bool pte_marker_entry_uffd_wp(swp_entry_t entry)
1db9dbc2ef05205 Peter Xu      2022-05-12  437  {
564509f441b4695 Chunyan Zhang 2025-09-15  438  	if (!uffd_supports_wp_marker())
564509f441b4695 Chunyan Zhang 2025-09-15  439  		return false;
564509f441b4695 Chunyan Zhang 2025-09-15  440  
1db9dbc2ef05205 Peter Xu      2022-05-12 @441  	return is_pte_marker_entry(entry) &&
1db9dbc2ef05205 Peter Xu      2022-05-12 @442  	       (pte_marker_get(entry) & PTE_MARKER_UFFD_WP);
1db9dbc2ef05205 Peter Xu      2022-05-12  443  }
1db9dbc2ef05205 Peter Xu      2022-05-12  444  
1db9dbc2ef05205 Peter Xu      2022-05-12  445  static inline bool pte_marker_uffd_wp(pte_t pte)
1db9dbc2ef05205 Peter Xu      2022-05-12  446  {
1db9dbc2ef05205 Peter Xu      2022-05-12  447  	swp_entry_t entry;
1db9dbc2ef05205 Peter Xu      2022-05-12  448  
564509f441b4695 Chunyan Zhang 2025-09-15  449  	if (!uffd_supports_wp_marker())
564509f441b4695 Chunyan Zhang 2025-09-15  450  		return false;
564509f441b4695 Chunyan Zhang 2025-09-15  451  
1db9dbc2ef05205 Peter Xu      2022-05-12 @452  	if (!is_swap_pte(pte))
1db9dbc2ef05205 Peter Xu      2022-05-12  453  		return false;
1db9dbc2ef05205 Peter Xu      2022-05-12  454  
1db9dbc2ef05205 Peter Xu      2022-05-12 @455  	entry = pte_to_swp_entry(pte);
1db9dbc2ef05205 Peter Xu      2022-05-12  456  
1db9dbc2ef05205 Peter Xu      2022-05-12  457  	return pte_marker_entry_uffd_wp(entry);
1db9dbc2ef05205 Peter Xu      2022-05-12  458  }
1db9dbc2ef05205 Peter Xu      2022-05-12  459  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ