linux-kernel - Re: [PATCH v4 18/19] drm/mediatek: Add support for multiple mmsys in the one mediatek-drm driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8ddf201e459cabd22772117857b0fe65a9171002.camel@mediatek.com>
Date: Tue, 16 Sep 2025 06:12:52 +0000
From: Paul-pl Chen (陳柏霖) <Paul-pl.Chen@...iatek.com>
To: "robh@...nel.org" <robh@...nel.org>, "krzk+dt@...nel.org"
	<krzk+dt@...nel.org>, AngeloGioacchino Del Regno
	<angelogioacchino.delregno@...labora.com>, "conor+dt@...nel.org"
	<conor+dt@...nel.org>, "chunkuang.hu@...nel.org" <chunkuang.hu@...nel.org>
CC: Sunny Shen (沈姍姍) <Sunny.Shen@...iatek.com>,
	Sirius Wang (王皓昱) <Sirius.Wang@...iatek.com>,
	Nancy Lin (林欣螢) <Nancy.Lin@...iatek.com>,
	Xiandong Wang (王先冬)
	<Xiandong.Wang@...iatek.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "dri-devel@...ts.freedesktop.org"
	<dri-devel@...ts.freedesktop.org>, Project_Global_Chrome_Upstream_Group
	<Project_Global_Chrome_Upstream_Group@...iatek.com>,
	"linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
	Jason-JH Lin (林睿祥) <Jason-JH.Lin@...iatek.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"fshao@...omium.org" <fshao@...omium.org>, "p.zabel@...gutronix.de"
	<p.zabel@...gutronix.de>, Singo Chang (張興國)
	<Singo.Chang@...iatek.com>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "matthias.bgg@...il.com"
	<matthias.bgg@...il.com>, "treapking@...omium.org" <treapking@...omium.org>
Subject: Re: [PATCH v4 18/19] drm/mediatek: Add support for multiple mmsys in
 the one mediatek-drm driver

On Wed, 2025-09-10 at 14:24 +0200, AngeloGioacchino Del Regno wrote:
> 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> Il 28/08/25 10:07, Paul Chen ha scritto:
> > From: Nancy Lin <nancy.lin@...iatek.com>
> > 
> > To support multiple mmsys instances in the one mediatek-drm
> > instance,
> > providing improved flexibility and scalability by the following
> > changes:
> > 
> > 1. Add DDP_COMPONENT_DRM_OVLSYS_ADAPTOR* to probe the
> >    ovlsys_adaptor drivers and support different mmsys composition.
> > 2. Added new component types MTK_DISP_VIRTUAL to support the
> >    routing to virtual display components.
> > 3. Added and adjusted the existed structure or interface to extend
> >    the support of multiple mmsys instances.
> > 4. Modified the component matching and binding logic to support
> >    multiple mmsys instances.
> 
> This commit is huge and a bit difficult to read, but also you have
> split the
> changes description in four points.
> 
> Please, split this in four commits, for each of the changes that
> you're actually
> describing in the description of this single one: this not only makes
> reviewing a
> bit easier, but will help understanding what's being done in case any
> uncaught
> regression shows up "after the fact".
> 
> Thanks,
> Angelo
> 

Hi Angelo, 

Sure, I will split this commit to four commits to make sure every
commit have only one changes. 

Best, Paul
> 
> > 
> > Signed-off-by: Nancy Lin <nancy.lin@...iatek.com>
> > Signed-off-by: Paul-pl Chen <paul-pl.chen@...iatek.com>
> > ---
> >   drivers/gpu/drm/mediatek/mtk_crtc.c     | 342
> > +++++++++++++++++++-----
> >   drivers/gpu/drm/mediatek/mtk_crtc.h     |   6 +-
> >   drivers/gpu/drm/mediatek/mtk_ddp_comp.c | 105 +++++---
> >   drivers/gpu/drm/mediatek/mtk_ddp_comp.h |   2 +
> >   drivers/gpu/drm/mediatek/mtk_drm_drv.c  |  85 +++---
> >   drivers/gpu/drm/mediatek/mtk_drm_drv.h  |  13 +
> >   6 files changed, 421 insertions(+), 132 deletions(-)
> >