linux-kernel - Re: [PATCH v2 1/2] ALSA: compress: add raw opus codec define and opus decoder structs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87ikhi3otv.wl-tiwai@suse.de>
Date: Tue, 16 Sep 2025 08:15:40 +0200
From: Takashi Iwai <tiwai@...e.de>
To: "Alexey Klimov" <alexey.klimov@...aro.org>
Cc: "Takashi Iwai" <tiwai@...e.de>,
	"Vinod Koul" <vkoul@...nel.org>,
	"Jaroslav Kysela" <perex@...ex.cz>,
	"Takashi Iwai" <tiwai@...e.com>,
	"Srinivas Kandagatla" <srini@...nel.org>,
	"Liam Girdwood" <lgirdwood@...il.com>,
	"Mark Brown" <broonie@...nel.org>,
	"Patrick Lai" <plai@....qualcomm.com>,
	"Annemarie Porter"
 <annemari@...cinc.com>,
	<srinivas.kandagatla@....qualcomm.com>,
	<linux-sound@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>,
	<linux-arm-msm@...r.kernel.org>,
	"Krzysztof Kozlowski"
 <krzysztof.kozlowski@...aro.org>,
	<kernel@....qualcomm.com>,
	"Ekansh Gupta"
 <ekansh.gupta@....qualcomm.com>,
	"Pierre-Louis Bossart"
 <pierre-louis.bossart@...ux.dev>
Subject: Re: [PATCH v2 1/2] ALSA: compress: add raw opus codec define and opus decoder structs

On Tue, 16 Sep 2025 06:20:31 +0200,
Alexey Klimov wrote:
> 
> Hi Takashi,
> 
> On Wed Sep 10, 2025 at 10:17 AM BST, Takashi Iwai wrote:
> > On Wed, 10 Sep 2025 10:11:41 +0200,
> > Alexey Klimov wrote:
> >> +struct snd_dec_opus {
> >> +	union {
> >> +		struct {
> >> +			__u8 minor:4;
> >> +			__u8 major:4;
> >> +		} __attribute__((packed)) fields;
> >
> > Bit fields aren't really good for ABI definition, as it's not well
> > defined.  I'd rather leave it as a u8.  If any, you can provide a
> > bitmask definition or a macro to retrieve the version numbers.
> 
> Okay.
> 
> > Also, don't forget to bump the API protocol number.
> > It's been already increased to 0.4.0 for 64bit tstamp support, and
> > yours need to increase one more.
> 
> Can you please advice if minor version should be increased i.e. it
> should become 0.4.1? Or should it 0.5.0?

0.4.1 should suffice in this case, I believe.

> > (That is, please make sure to create patches based on linux-next, or
> >  for-next branch of sound git tree.)
> 
> Previous and this one were (re)based on linux-next at the time of
> sending. I didn't really verify against for-next branch of sound git
> tree (I know I should).

linux-next should be fine.  The compress-offload 64bit timestamp
change was merged recently, so you might have missed it when you
created the patch.


thanks,

Takashi