linux-kernel - Re: [PATCH] PM / devfreq: hisi: Fix potential UAF in OPP handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bdc702db-a898-4b92-bc5f-db802fe235b5@hisilicon.com>
Date: Tue, 16 Sep 2025 09:10:22 +0800
From: Jie Zhan <zhanjie9@...ilicon.com>
To: Pengjie Zhang <zhangpengjie2@...wei.com>, <myungjoo.ham@...sung.com>,
	<kyungmin.park@...sung.com>, <cw00.choi@...sung.com>
CC: <linux-pm@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<zhenglifeng1@...wei.com>, <lihuisong@...wei.com>, <yubowen8@...wei.com>,
	<linhongye@...artners.com>, <linuxarm@...wei.com>,
	<jonathan.cameron@...wei.com>
Subject: Re: [PATCH] PM / devfreq: hisi: Fix potential UAF in OPP handling



On 9/15/2025 2:21 PM, Pengjie Zhang wrote:
> Ensure all required data is acquired before calling dev_pm_opp_put(opp)
> to maintain correct resource acquisition and release order.
> 
> Fixes: 7da2fdaaa1e6 ("PM / devfreq: Add HiSilicon uncore frequency scaling driver")
> Signed-off-by: Pengjie Zhang <zhangpengjie2@...wei.com>
> ---
>  drivers/devfreq/hisi_uncore_freq.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
Hi Pengjie,

Yeah dev_pm_opp_put() should be after dev_pm_opp_get_freq().
Thanks for spotting this.

Reviewed-by: Jie Zhan <zhanjie9@...ilicon.com>
> 
> diff --git a/drivers/devfreq/hisi_uncore_freq.c b/drivers/devfreq/hisi_uncore_freq.c
> index 96d1815059e3..c1ed70fa0a40 100644
> --- a/drivers/devfreq/hisi_uncore_freq.c
> +++ b/drivers/devfreq/hisi_uncore_freq.c
> @@ -265,10 +265,11 @@ static int hisi_uncore_target(struct device *dev, unsigned long *freq,
>  		dev_err(dev, "Failed to get opp for freq %lu hz\n", *freq);
>  		return PTR_ERR(opp);
>  	}
> -	dev_pm_opp_put(opp);
>  
>  	data = (u32)(dev_pm_opp_get_freq(opp) / HZ_PER_MHZ);
>  
> +	dev_pm_opp_put(opp);
> +
>  	return hisi_uncore_cmd_send(uncore, HUCF_PCC_CMD_SET_FREQ, &data);
>  }
>