linux-kernel - [RFC] net: selftests: Adding TX checksum offload validation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <aMkp4vGilSPbAyun@pengutronix.de>
Date: Tue, 16 Sep 2025 11:12:02 +0200
From: Oleksij Rempel <o.rempel@...gutronix.de>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
	kernel@...gutronix.de, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org
Subject: [RFC] net: selftests: Adding TX checksum offload validation

Hello everyone,

While working with the smsc95xx driver, I identified a need for better
validation of the driver and hardware TX checksum offloading capabilities. I
believe a generic test suite for this would benefit other drivers as well.

The generic selftest framework in net/core/selftests.c seems like the ideal
location. It already contains a test for the RX checksum path, so adding
validation for the TX path feels like a natural extension.

Here is the list of test cases I propose to add:
- TX csum offload, IPv4, TCP, Standard MTU Packet
- TX csum offload, IPv4, UDP, Standard MTU Packet
- TX csum offload, IPv4, ICMP, Standard Payload
- TX csum offload, IPv4, TCP, Minimal Size Packet (1-byte payload)
- TX csum offload, IPv4, UDP, Minimal Size Packet (1-byte payload)
- TX csum offload, IPv4, UDP, Zero-Checksum Payload (Verify checksum becomes
                              0xFFFF)
- TX csum offload, IPv4, TCP, With Single VLAN Tag
- TX csum offload, IPv4, TCP, With Double VLAN Tag (Q-in-Q)
- TX csum offload, IPv6, TCP, Standard MTU Packet
- TX csum offload, IPv6, UDP, Standard MTU Packet

The implementation for these tests would involve preparing an skb with the
corresponding L3/L4 headers, flagging it with CHECKSUM_PARTIAL, and sending it
through the PHY loopback. The test would pass if the received frame has a
valid checksum.

As a related question on driver implementation:
The documentation suggests that the older flags NETIF_F_IP_CSUM and
NETIF_F_IPV6_CSUM are being superseded by the more generic NETIF_F_HW_CSUM.
When the network stack sends a packet with skb->ip_summed = CHECKSUM_PARTIAL,
the driver is responsible for ensuring the final checksum is correct, either by
offloading the calculation to the device or by falling back to a software
function like skb_checksum_help().

Is this understanding correct, and is relying on CHECKSUM_PARTIAL as the
primary mechanism for requesting TX offload the recommended practice for modern
network drivers?

Thanks,
Oleksij
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |