linux-kernel - Re: [PATCH v1] platform/x86: asus-wmi: Re-add extra keys to ignore_key

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <30d3b204-c37d-0878-ee39-f5b14981197a@linux.intel.com>
Date: Tue, 16 Sep 2025 14:15:38 +0300 (EEST)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Antheas Kapenekakis <lkml@...heas.dev>, Rahul Chandra <rahul@...ndra.net>
cc: platform-driver-x86@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>, 
    Corentin Chary <corentin.chary@...il.com>, 
    "Luke D . Jones" <luke@...nes.dev>, Hans de Goede <hansg@...nel.org>, 
    stable@...nel.org
Subject: Re: [PATCH v1] platform/x86: asus-wmi: Re-add extra keys to
 ignore_key_wlan quirk

On Tue, 16 Sep 2025, Antheas Kapenekakis wrote:

> It turns out that the dual screen models use 0x5E for attaching and
> detaching the keyboard instead of 0x5F. So, re-add the codes by
> reverting commit cf3940ac737d ("platform/x86: asus-wmi: Remove extra
> keys from ignore_key_wlan quirk"). For our future reference, add a
> comment next to 0x5E indicating that it is used for that purpose.
> 
> Fixes: cf3940ac737d ("platform/x86: asus-wmi: Remove extra keys from ignore_key_wlan quirk")
> Reported-by: Rahul Chandra <rahul@...ndra.net>
> Closes: https://lore.kernel.org/all/10020-68c90c80-d-4ac6c580@106290038/
> Cc: stable@...nel.org
> Signed-off-by: Antheas Kapenekakis <lkml@...heas.dev>

Thank you both, I've taken this to the review-ilpo-fixes branch.

And I'm sorry for the breakage (I was skeptical about removing those keys 
right from the start even if the original commit's changelog wasn't 
explaining these extra keys with the detail it should have to avoid us 
having to second guess).

If Rahul has actually tested the direct revert or this patch and wants to 
provide a Tested-by tag, I can still embed that into the commit until I 
push the pending changes to Linus.

> ---
>  drivers/platform/x86/asus-nb-wmi.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c
> index 3a488cf9ca06..6a62bc5b02fd 100644
> --- a/drivers/platform/x86/asus-nb-wmi.c
> +++ b/drivers/platform/x86/asus-nb-wmi.c
> @@ -673,6 +673,8 @@ static void asus_nb_wmi_key_filter(struct asus_wmi_driver *asus_wmi, int *code,
>  		if (atkbd_reports_vol_keys)
>  			*code = ASUS_WMI_KEY_IGNORE;
>  		break;
> +	case 0x5D: /* Wireless console Toggle */
> +	case 0x5E: /* Wireless console Enable / Keyboard Attach, Detach */
>  	case 0x5F: /* Wireless console Disable / Special Key */
>  		if (quirks->key_wlan_event)
>  			*code = quirks->key_wlan_event;
> 
> base-commit: 46a51f4f5edade43ba66b3c151f0e25ec8b69cb6
> 

-- 
 i.