linux-kernel - Re: [PATCH v2 7/9] panic/printk: replace this_cpu_in_panic() with panic_on_this

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aMlIi9cT7xiYWo29@pathway.suse.cz>
Date: Tue, 16 Sep 2025 13:22:51 +0200
From: Petr Mladek <pmladek@...e.com>
To: Jinchao Wang <wangjinchao600@...il.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>, Baoquan He <bhe@...hat.com>,
	Yury Norov <yury.norov@...il.com>,
	Qianqiang Liu <qianqiang.liu@....com>,
	Simona Vetter <simona@...ll.ch>, Helge Deller <deller@....de>,
	Steven Rostedt <rostedt@...dmis.org>,
	John Ogness <john.ogness@...utronix.de>,
	Sergey Senozhatsky <senozhatsky@...omium.org>,
	Vivek Goyal <vgoyal@...hat.com>, Dave Young <dyoung@...hat.com>,
	Kees Cook <kees@...nel.org>, Tony Luck <tony.luck@...el.com>,
	"Guilherme G. Piccoli" <gpiccoli@...lia.com>,
	Thomas Zimmermann <tzimmermann@...e.de>,
	Ville Syrjälä <ville.syrjala@...ux.intel.com>,
	Shixiong Ou <oushixiong@...inos.cn>,
	Zsolt Kajtar <soci@....rulez.org>, Ingo Molnar <mingo@...nel.org>,
	Nam Cao <namcao@...utronix.de>,
	Jonathan Cameron <Jonathan.Cameron@...wei.com>,
	Joel Fernandes <joelagnelf@...dia.com>,
	Joel Granados <joel.granados@...nel.org>,
	Jason Gunthorpe <jgg@...pe.ca>, Sohil Mehta <sohil.mehta@...el.com>,
	Feng Tang <feng.tang@...ux.alibaba.com>,
	Sravan Kumar Gundu <sravankumarlpu@...il.com>,
	Douglas Anderson <dianders@...omium.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Anna Schumaker <anna.schumaker@...cle.com>,
	"Darrick J. Wong" <djwong@...nel.org>,
	Max Kellermann <max.kellermann@...os.com>,
	Yunhui Cui <cuiyunhui@...edance.com>, Tejun Heo <tj@...nel.org>,
	Luo Gengkun <luogengkun@...weicloud.com>,
	Li Huafei <lihuafei1@...wei.com>,
	Thorsten Blum <thorsten.blum@...ux.dev>,
	Yicong Yang <yangyicong@...ilicon.com>, linux-fbdev@...r.kernel.org,
	dri-devel@...ts.freedesktop.org, kexec@...ts.infradead.org,
	linux-hardening@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 7/9] panic/printk: replace this_cpu_in_panic() with
 panic_on_this_cpu()

On Mon 2025-08-25 10:29:35, Jinchao Wang wrote:
> The helper this_cpu_in_panic() duplicated logic already provided by
> panic_on_this_cpu().
> 
> Remove this_cpu_in_panic() and switch all users to panic_on_this_cpu().
> 
> This simplifies the code and avoids having two helpers for the same check.
> 
> Signed-off-by: Jinchao Wang <wangjinchao600@...il.com>

It is great that the helper functions were consolidated and moved
from printk to panic code.

Reviewed-by: Petr Mladek <pmladek@...e.com>

Best Regards,
Petr