linux-kernel - Re: [RFC PATCH v2] net: add net-device TX clock source selection framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <42xbm6obaa22qoictrgaeqza76iucvasquthb3igqhozrlxmbl@dtspujve2njn>
Date: Tue, 16 Sep 2025 14:04:40 +0200
From: Jiri Pirko <jiri@...nulli.us>
To: "Kubalewski, Arkadiusz" <arkadiusz.kubalewski@...el.com>
Cc: Mina Almasry <almasrymina@...gle.com>, 
	"Nguyen, Anthony L" <anthony.l.nguyen@...el.com>, "Kitszel, Przemyslaw" <przemyslaw.kitszel@...el.com>, 
	"andrew+netdev@...n.ch" <andrew+netdev@...n.ch>, "davem@...emloft.net" <davem@...emloft.net>, 
	"edumazet@...gle.com" <edumazet@...gle.com>, "kuba@...nel.org" <kuba@...nel.org>, 
	"pabeni@...hat.com" <pabeni@...hat.com>, "horms@...nel.org" <horms@...nel.org>, 
	"sdf@...ichev.me" <sdf@...ichev.me>, "asml.silence@...il.com" <asml.silence@...il.com>, 
	"leitao@...ian.org" <leitao@...ian.org>, "kuniyu@...gle.com" <kuniyu@...gle.com>, 
	"Loktionov, Aleksandr" <aleksandr.loktionov@...el.com>, "Vecera, Ivan" <ivecera@...hat.com>, 
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, 
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [RFC PATCH v2] net: add net-device TX clock source selection
 framework

Fri, Aug 29, 2025 at 09:05:02AM +0200, arkadiusz.kubalewski@...el.com wrote:
>>From: Mina Almasry <almasrymina@...gle.com>
>>Sent: Thursday, August 28, 2025 6:58 PM
>>
>>On Thu, Aug 28, 2025 at 9:50 AM Arkadiusz Kubalewski
>><arkadiusz.kubalewski@...el.com> wrote:
>>> ---
>>>  Documentation/netlink/specs/netdev.yaml     |  61 +++++
>>>  drivers/net/ethernet/intel/ice/Makefile     |   1 +
>>>  drivers/net/ethernet/intel/ice/ice.h        |   5 +
>>>  drivers/net/ethernet/intel/ice/ice_lib.c    |   6 +
>>>  drivers/net/ethernet/intel/ice/ice_main.c   |   6 +
>>>  drivers/net/ethernet/intel/ice/ice_tx_clk.c | 100 +++++++
>>> drivers/net/ethernet/intel/ice/ice_tx_clk.h |  17 ++
>>>  include/linux/netdev_tx_clk.h               |  92 +++++++
>>>  include/linux/netdevice.h                   |   4 +
>>>  include/uapi/linux/netdev.h                 |  18 ++
>>>  net/Kconfig                                 |  21 ++
>>>  net/core/Makefile                           |   1 +
>>>  net/core/netdev-genl-gen.c                  |  37 +++
>>>  net/core/netdev-genl-gen.h                  |   4 +
>>>  net/core/netdev-genl.c                      | 287 ++++++++++++++++++++
>>>  net/core/tx_clk.c                           | 218 +++++++++++++++
>>>  net/core/tx_clk.h                           |  36 +++
>>>  tools/include/uapi/linux/netdev.h           |  18 ++
>>>  18 files changed, 932 insertions(+)
>>
>>Consider breaking up a change of this size in a patch series to make it a
>>bit easier for reviewers, if it makes sense to you.
>>
>>--
>>Thanks,
>>Mina
>
>Yes, will surely do for non-RFC submission.

Please, do it always. You request for comment of something you make hard
to read. Does not make sense to me :/


>
>Thank you!
>Arkadiusz