linux-kernel - Re: [PATCH v2 01/13] memory: tegra124-emc: Simplify return of emc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0a0ca1f0-fa07-49b3-ad7f-0a5f485ac505@nvidia.com>
Date: Wed, 17 Sep 2025 14:12:20 +0100
From: Jon Hunter <jonathanh@...dia.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
 Krzysztof Kozlowski <krzk@...nel.org>,
 Thierry Reding <thierry.reding@...il.com>
Cc: linux-kernel@...r.kernel.org, linux-tegra@...r.kernel.org,
 Aaron Kling <webgeek1234@...il.com>
Subject: Re: [PATCH v2 01/13] memory: tegra124-emc: Simplify return of
 emc_init()


On 11/09/2025 10:43, Krzysztof Kozlowski wrote:
> emc_init() returns always success, so just drop return valye to simplify

s/valye/value/

> it.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
>   drivers/memory/tegra/tegra124-emc.c | 10 ++--------
>   1 file changed, 2 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/memory/tegra/tegra124-emc.c b/drivers/memory/tegra/tegra124-emc.c
> index 03f1daa2d132a81d28705ec7c62d640d7d25a894..9aad02901613f1b2ed855c11bcd76fef153034af 100644
> --- a/drivers/memory/tegra/tegra124-emc.c
> +++ b/drivers/memory/tegra/tegra124-emc.c
> @@ -896,7 +896,7 @@ static void emc_read_current_timing(struct tegra_emc *emc,
>   	timing->emc_mode_reset = 0;
>   }
>   
> -static int emc_init(struct tegra_emc *emc)
> +static void emc_init(struct tegra_emc *emc)
>   {
>   	emc->dram_type = readl(emc->regs + EMC_FBIO_CFG5);
>   
> @@ -913,8 +913,6 @@ static int emc_init(struct tegra_emc *emc)
>   	emc->dram_num = tegra_mc_get_emem_device_count(emc->mc);
>   
>   	emc_read_current_timing(emc, &emc->last_timing);
> -
> -	return 0;
>   }
>   
>   static int load_one_timing_from_dt(struct tegra_emc *emc,
> @@ -1472,11 +1470,7 @@ static int tegra_emc_probe(struct platform_device *pdev)
>   			      ram_code);
>   	}
>   
> -	err = emc_init(emc);
> -	if (err) {
> -		dev_err(&pdev->dev, "EMC initialization failed: %d\n", err);
> -		return err;
> -	}
> +	emc_init(emc);
>   
>   	platform_set_drvdata(pdev, emc);
>   

Otherwise looks good to me.

Reviewed-by: Jon Hunter <jonathanh@...dia.com>

Cheers
Jon

-- 
nvpublic