linux-kernel - Re: [PATCH 0/3] scsi: qla2xxx: Fix incorrect sign of error code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <yq1348lzvbp.fsf@ca-mkp.ca.oracle.com>
Date: Tue, 16 Sep 2025 22:06:41 -0400
From: "Martin K. Petersen" <martin.petersen@...cle.com>
To: Qianfeng Rong <rongqianfeng@...o.com>
Cc: Nilesh Javali <njavali@...vell.com>,
        GR-QLogic-Storage-Upstream@...vell.com (maintainer:QLOGIC QLA2XXX FC-SCSI
 DRIVER,blamed_fixes:1/1=100%),
        "James E.J. Bottomley"
 <James.Bottomley@...senPartnership.com>,
        "Martin K. Petersen"
 <martin.petersen@...cle.com>,
        Quinn Tran <qutran@...vell.com>, himanshu.madhani@...cle.com,
        Manish Rangankar <mrangankar@...vell.com>,
        linux-scsi@...r.kernel.org (open list:QLOGIC QLA2XXX FC-SCSI DRIVER),
        linux-kernel@...r.kernel.org (open list)
Subject: Re: [PATCH 0/3] scsi: qla2xxx: Fix incorrect sign of error code


Qianfeng,

> qla2x00_start_sp() returns only negative error codes or QLA_SUCCESS.
> Therefore, comparing its return value with positive error codes 
> (e.g., if (_rval == EAGAIN)) causes logical errors.

Applied to 6.18/scsi-staging, thanks!

-- 
Martin K. Petersen