linux-kernel - Re: [PATCH v2 02/13] arm64: dts: qcom: sdm845-lg-common: Add uarts and Bluetooth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4428ea30-7324-4faf-98a6-b18eb16f9fc8@oss.qualcomm.com>
Date: Wed, 17 Sep 2025 15:40:54 +0200
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: Paul Sajna <sajattack@...tmarketos.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley
 <conor+dt@...nel.org>, David Heidelberg <david@...t.cz>
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, phone-devel@...r.kernel.org,
        Amir Dahan <system64fumo@...tonmail.com>,
        Christopher Brown <crispybrown@...il.com>
Subject: Re: [PATCH v2 02/13] arm64: dts: qcom: sdm845-lg-common: Add uarts
 and Bluetooth

On 9/17/25 3:09 AM, Paul Sajna wrote:
> uart9 is debug serial on USB SBU1/2
> uart6 is bluetooth
> 
> Signed-off-by: Paul Sajna <sajattack@...tmarketos.org>
> ---

I would imagine the SBU uart requires a jig or some other config..

Could you put that information in the commit message?


[...]

> +&uart6 {
> +	bluetooth {

It'd be better if you introduced a new label for the bt node and
referred to it by that label here

> +		/*
> +		 * This path is relative to the qca/
> +		 * subdir under lib/firmware.
> +		 */

This comment is a little redundant

> +		firmware-name = "judyln/crnv21.bin";

Is that fw different to other SDM845 LG firmwares?

Konrad