linux-kernel - Re: [RFC v1 1/2] PCI: tegra: Simplify clock handling by using clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a743fd19-d54b-450f-a4db-8efc21acf22a@nvidia.com>
Date: Wed, 17 Sep 2025 14:44:38 +0100
From: Jon Hunter <jonathanh@...dia.com>
To: Anand Moon <linux.amoon@...il.com>,
 Thierry Reding <thierry.reding@...il.com>,
 Lorenzo Pieralisi <lpieralisi@...nel.org>,
 Krzysztof Wilczyński <kwilczynski@...nel.org>,
 Manivannan Sadhasivam <mani@...nel.org>, Rob Herring <robh@...nel.org>,
 Bjorn Helgaas <bhelgaas@...gle.com>,
 "open list:PCI DRIVER FOR NVIDIA TEGRA" <linux-tegra@...r.kernel.org>,
 "open list:PCI DRIVER FOR NVIDIA TEGRA" <linux-pci@...r.kernel.org>,
 open list <linux-kernel@...r.kernel.org>
Subject: Re: [RFC v1 1/2] PCI: tegra: Simplify clock handling by using
 clk_bulk*() functions


On 31/08/2025 20:00, Anand Moon wrote:
> Currently, the driver acquires clocks and prepare/enable/disable/unprepare
> the clocks individually thereby making the driver complex to read.
> 
> The driver can be simplified by using the clk_bulk*() APIs.
> 
> Use:
>    - devm_clk_bulk_get_all() API to acquire all the clocks
>    - clk_bulk_prepare_enable() to prepare/enable clocks
>    - clk_bulk_disable_unprepare() APIs to disable/unprepare them in bulk
> 
> As part of this cleanup, the legacy has_cml_clk flag and explicit handling
> of individual clocks (pex, afi, pll_e, cml) are removed. Clock sequencing
> is now implicitly determined by the order defined in the device tree,
> eliminating hardcoded logic and improving maintainability.

What platforms have you tested this change on?

Thanks
Jon

-- 
nvpublic