linux-kernel - Re: [PATCH] scsi: lpfc: Use int type to store negative error codes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <175798566833.3116853.69252163477869377.b4-ty@oracle.com>
Date: Tue, 16 Sep 2025 22:27:10 -0400
From: "Martin K. Petersen" <martin.petersen@...cle.com>
To: James Smart <james.smart@...adcom.com>,
        Dick Kennedy <dick.kennedy@...adcom.com>,
        "James E.J. Bottomley" <James.Bottomley@...senPartnership.com>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        Qianfeng Rong <rongqianfeng@...o.com>
Cc: "Martin K . Petersen" <martin.petersen@...cle.com>
Subject: Re: [PATCH] scsi: lpfc: Use int type to store negative error codes

On Thu, 04 Sep 2025 21:23:51 +0800, Qianfeng Rong wrote:

> Change the 'ret' variable in lpfc_sli4_issue_wqe() from uint32_t to int,
> as it needs to store either negative error codes or zero returned by
> lpfc_sli4_wq_put().
> 
> Storing the negative error codes in unsigned type, doesn't cause an issue
> at runtime but can be confusing.  Additionally, assigning negative error
> codes to unsigned type may trigger a GCC warning when the -Wsign-conversion
> flag is enabled.
> 
> [...]

Applied to 6.18/scsi-queue, thanks!

[1/1] scsi: lpfc: Use int type to store negative error codes
      https://git.kernel.org/mkp/scsi/c/5cffc679ad1d

-- 
Martin K. Petersen