linux-kernel - Re: [PATCH v2 16/16] selftests: vDSO: vdso_standalone_test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250917153209.GA2023406@nvidia.com>
Date: Wed, 17 Sep 2025 12:32:09 -0300
From: Jason Gunthorpe <jgg@...dia.com>
To: Thomas Weißschuh <thomas.weissschuh@...utronix.de>
Cc: Kees Cook <kees@...nel.org>, Eric Biederman <ebiederm@...ssion.com>,
	Shuah Khan <shuah@...nel.org>,
	Nathan Chancellor <nathan@...nel.org>,
	Nick Desaulniers <ndesaulniers@...gle.com>,
	Bill Wendling <morbo@...gle.com>,
	Justin Stitt <justinstitt@...gle.com>,
	Andy Lutomirski <luto@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Vincenzo Frascino <vincenzo.frascino@....com>,
	Willy Tarreau <w@....eu>,
	Thomas Weißschuh <linux@...ssschuh.net>,
	"Jason A. Donenfeld" <Jason@...c4.com>,
	Christophe Leroy <christophe.leroy@...roup.eu>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
	llvm@...ts.linux.dev
Subject: Re: [PATCH v2 16/16] selftests: vDSO: vdso_standalone_test_x86:
 Switch to nolibc

On Wed, Feb 26, 2025 at 12:44:55PM +0100, Thomas Weißschuh wrote:

> -$(OUTPUT)/vdso_standalone_test_x86: vdso_standalone_test_x86.c parse_vdso.c
> -$(OUTPUT)/vdso_standalone_test_x86: CFLAGS +=-nostdlib -fno-asynchronous-unwind-tables -fno-stack-protector
> +$(OUTPUT)/vdso_standalone_test_x86: vdso_standalone_test_x86.c parse_vdso.c | headers
> +$(OUTPUT)/vdso_standalone_test_x86: CFLAGS:=$(CFLAGS_NOLIBC) $(CFLAGS)

This addition of "| headers" breaks O=build builds. ie this:

$ make O=build-x86 allnoconfig -s -j 14
$ make O=build-x86 -s -j 14
$ make O=build-x86 kselftest-all -s -j 16 &> /dev/null || true
$ make O=build-x86 -s -j 14

Fails with:

***
*** The source tree is not clean, please run 'make mrproper'
*** in /home/jgg/oss/wip/kselftests_dirty
***

Because the build now spews stuff outside the build directory that it
should not do.. Bisection points to this patch and removing the "|
headers" makes it stop doing that..

Any idea how to fix it?

Thanks,
Jason