linux-kernel - Re: [Jfs-discussion] [PATCH] JFS: Remove redundant 0 value initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c6d3d5d7-3a34-4d19-b404-498ea4714bf5@oracle.com>
Date: Wed, 17 Sep 2025 13:40:33 -0500
From: Dave Kleikamp <dave.kleikamp@...cle.com>
To: Liao Yuanhong <liaoyuanhong@...o.com>,
        "open list:JFS FILESYSTEM" <jfs-discussion@...ts.sourceforge.net>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [Jfs-discussion] [PATCH] JFS: Remove redundant 0 value
 initialization

Applied.

Thanks,
Shaggy

On 8/18/25 10:28PM, Liao Yuanhong via Jfs-discussion wrote:
> The jfs_log struct is already zeroed by kzalloc(). It's redundant to
> initialize dummy_log->base to 0.
> 
> Signed-off-by: Liao Yuanhong <liaoyuanhong@...o.com>
> ---
>   fs/jfs/jfs_logmgr.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/fs/jfs/jfs_logmgr.c b/fs/jfs/jfs_logmgr.c
> index 270808b6219b..b343c5ea1159 100644
> --- a/fs/jfs/jfs_logmgr.c
> +++ b/fs/jfs/jfs_logmgr.c
> @@ -1199,7 +1199,6 @@ static int open_dummy_log(struct super_block *sb)
>   		init_waitqueue_head(&dummy_log->syncwait);
>   		dummy_log->no_integrity = 1;
>   		/* Make up some stuff */
> -		dummy_log->base = 0;
>   		dummy_log->size = 1024;
>   		rc = lmLogInit(dummy_log);
>   		if (rc) {