linux-kernel - Re: [External] : [v7, net-next 08/10] bng

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2d51927d-98b6-4bc6-92ca-0dcfef0e31f1@oracle.com>
Date: Thu, 18 Sep 2025 01:44:08 +0530
From: ALOK TIWARI <alok.a.tiwari@...cle.com>
To: Bhargava Marreddy <bhargava.marreddy@...adcom.com>, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        andrew+netdev@...n.ch, horms@...nel.org
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        michael.chan@...adcom.com, pavan.chebbi@...adcom.com,
        vsrama-krishna.nemani@...adcom.com, vikas.gupta@...adcom.com,
        Rajashekar Hudumula <rajashekar.hudumula@...adcom.com>
Subject: Re: [External] : [v7, net-next 08/10] bng_en: Register rings with the
 firmware



On 9/12/2025 1:05 AM, Bhargava Marreddy wrote:
> +int hwrm_ring_free_send_msg(struct bnge_net *bn,
> +			    struct bnge_ring_struct *ring,
> +			    u32 ring_type, int cmpl_ring_id)
> +{
> +	struct hwrm_ring_free_input *req;
> +	struct bnge_dev *bd = bn->bd;
> +	int rc;
> +
> +	rc = bnge_hwrm_req_init(bd, req, HWRM_RING_FREE);
> +	if (rc)
> +		goto exit;
> +
> +	req->cmpl_ring = cpu_to_le16(cmpl_ring_id);
> +	req->ring_type = ring_type;

req->ring_type is a u8, but u32 ring_type uses here
since the enums (0x0, ->0x5) fit in 8 bits
That is not a mismatch but it is misleading.
it can use u8 ?

> +	req->ring_id = cpu_to_le16(ring->fw_ring_id);
> +
> +	bnge_hwrm_req_hold(bd, req);
> +	rc = bnge_hwrm_req_send(bd, req);
> +	bnge_hwrm_req_drop(bd, req);
> +exit:
> +	if (rc) {
> +		netdev_err(bd->netdev, "hwrm_ring_free type %d failed. rc:%d\n", ring_type, rc);
> +		return -EIO;
> +	}
> +	return 0;
> +}


Thanks,
Alok