linux-kernel - Re: [PATCH] dt-bindings: iio: light: APDS9160: fix missing type definition warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3a2096ed-a12b-4e36-aa3b-cec3353bb39d@baylibre.com>
Date: Wed, 17 Sep 2025 16:12:40 -0500
From: David Lechner <dlechner@...libre.com>
To: Yixun Lan <dlan@...too.org>,
 Mikael Gonella-Bolduc <m.gonella.bolduc@...il.com>,
 Jonathan Cameron <jic23@...nel.org>, Nuno Sá
 <nuno.sa@...log.com>, Andy Shevchenko <andy@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>
Cc: linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: iio: light: APDS9160: fix missing type
 definition warning

On 9/17/25 4:02 PM, Yixun Lan wrote:
> DT validation will report missing type definition warning for the property of
> 'ps-cancellation-current-picoamp', explicitly add type definition to fix it.
> 
> Signed-off-by: Yixun Lan <dlan@...too.org>
> ---
> I got following DT warning, when running dtbs_check
> 
> $ make ARCH=riscv CROSS_COMPILE=riscv64-unknown-linux-gnu- dtbs_check W=1
> generic check all files
>   UPD     include/config/kernel.release
>   SCHEMA  Documentation/devicetree/bindings/processed-schema.json
> /home/work/linux-6.y/Documentation/devicetree/bindings/iio/light/brcm,apds9160.yaml: ps-cancellation-current-picoamp: missing type definition
> ---
>  Documentation/devicetree/bindings/iio/light/brcm,apds9160.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/light/brcm,apds9160.yaml b/Documentation/devicetree/bindings/iio/light/brcm,apds9160.yaml
> index bb1cc4404a55760d3f2ef3818d8f5c14782dc5b8..f9c35c29fe04c3623349b636a0dd7ffa4ea24a14 100644
> --- a/Documentation/devicetree/bindings/iio/light/brcm,apds9160.yaml
> +++ b/Documentation/devicetree/bindings/iio/light/brcm,apds9160.yaml
> @@ -37,6 +37,7 @@ properties:
>      maximum: 63
>  
>    ps-cancellation-current-picoamp:
> +    $ref: /schemas/types.yaml#/definitions/uint32

`-picoamp` is already a standard property suffix [1]. Git blame says it
was added 8 months ago, so maybe you haven't updated dtschema in a while?

[1]: https://github.com/devicetree-org/dt-schema/blob/4b28bc79fdc552f3e0b870ef1362bb711925f4f3/dtschema/schemas/property-units.yaml#L92

>      description:
>        Proximity sensor crosstalk cancellation current in picoampere.
>        This parameter adjusts the current in steps of 2400 pA up to 276000 pA.
> 
> ---
> base-commit: 8f5ae30d69d7543eee0d70083daf4de8fe15d585
> change-id: 20250918-60-dt-iio-apds9160-bdb725db100d
> 
> Best regards,