linux-kernel - Re: [PATCH 0/4] hwmon: (dell-smm) Add support for automatic fan mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250917211925.dhzocprqgo4tkpte@pali>
Date: Wed, 17 Sep 2025 23:19:25 +0200
From: Pali Rohár <pali@...nel.org>
To: Armin Wolf <W_Armin@....de>
Cc: linux@...ck-us.net, linux-hwmon@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/4] hwmon: (dell-smm) Add support for automatic fan mode

On Wednesday 17 September 2025 20:10:32 Armin Wolf wrote:
> This patch series adds support for individually enabling and disabling
> automatic fan control for each fan on most Dell machines. This works
> by using fan state 3 that does not act like an ordinary fan state on
> most devices. Instead of increasing the speed, said fan state usually
> enables automatic fan control for the associated fan.
> 
> The first patch removes the custom config data for the Precision 490
> that turned out to be incorrect, see the link inside the patch
> description for details.
> 
> The second patch enables i8k_set_fan() to accept fan states larger
> than i8k_fan_max to prepare for the following patch.
> 
> The third patch finally adds support for this special fan state. It
> should be noted that after applying this patch, the "pwmX" and
> "fanX_target" sysfs attributes will return -ENODATA when automatic fan
> control has been enabled for fan X using the special fan state.
> 
> The last patch adds the OptiPlex 7040 to the device whitelist so that
> the driver automatically loads on those machine.
> 
> All patches have been tested on a Dell Inspiron 3505 and appear to
> work.
> 
> Armin Wolf (4):
>   hwmon: (dell-smm) Remove Dell Precision 490 custom config data
>   hwmon: (dell-smm) Move clamping of fan speed out of i8k_set_fan()
>   hwmon: (dell-smm) Add support for automatic fan mode
>   hwmon: (dell-smm) Add support for Dell OptiPlex 7040
> 
>  Documentation/hwmon/dell-smm-hwmon.rst | 56 +++++++++------
>  drivers/hwmon/dell-smm-hwmon.c         | 99 ++++++++++++++++++--------
>  include/uapi/linux/i8k.h               |  2 +
>  3 files changed, 108 insertions(+), 49 deletions(-)
> 
> -- 
> 2.39.5
> 

This patch series looks good to me.
Acked-by: Pali Rohár <pali@...nel.org>