| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202509180501.eB8FJ5Vt-lkp@intel.com>
Date: Thu, 18 Sep 2025 06:01:36 +0800
From: kernel test robot <lkp@...el.com>
To: Shuai Xue <xueshuai@...ux.alibaba.com>, bhelgaas@...gle.com,
mahesh@...ux.ibm.com, mani@...nel.org, Jonathan.Cameron@...wei.com,
sathyanarayanan.kuppuswamy@...ux.intel.com
Cc: oe-kbuild-all@...ts.linux.dev, oohall@...il.com,
xueshuai@...ux.alibaba.com, linux-pci@...r.kernel.org,
linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH v5 2/3] PCI/DPC: Run recovery on device that detected the
error
Hi Shuai,
kernel test robot noticed the following build warnings:
[auto build test WARNING on pci/for-linus]
[also build test WARNING on linus/master v6.17-rc6 next-20250917]
[cannot apply to pci/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Shuai-Xue/PCI-DPC-Clarify-naming-for-error-port-in-DPC-Handling/20250917-143459
base: https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git for-linus
patch link: https://lore.kernel.org/r/20250917063352.19429-3-xueshuai%40linux.alibaba.com
patch subject: [PATCH v5 2/3] PCI/DPC: Run recovery on device that detected the error
config: loongarch-allyesconfig (https://download.01.org/0day-ci/archive/20250918/202509180501.eB8FJ5Vt-lkp@intel.com/config)
compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project 7c861bcedf61607b6c087380ac711eb7ff918ca6)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250918/202509180501.eB8FJ5Vt-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202509180501.eB8FJ5Vt-lkp@intel.com/
All warnings (new ones prefixed by >>):
In file included from <built-in>:3:
In file included from include/linux/compiler_types.h:171:
include/linux/compiler-clang.h:28:9: warning: '__SANITIZE_ADDRESS__' macro redefined [-Wmacro-redefined]
28 | #define __SANITIZE_ADDRESS__
| ^
<built-in>:371:9: note: previous definition is here
371 | #define __SANITIZE_ADDRESS__ 1
| ^
>> drivers/pci/pcie/edr.c:188:6: warning: variable 'err_dev' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
188 | if (!(status & PCI_EXP_DPC_STATUS_TRIGGER)) {
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/pci/pcie/edr.c:218:14: note: uninitialized use occurs here
218 | pci_dev_put(err_dev);
| ^~~~~~~
drivers/pci/pcie/edr.c:188:2: note: remove the 'if' if its condition is always false
188 | if (!(status & PCI_EXP_DPC_STATUS_TRIGGER)) {
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
189 | pci_err(err_port, "Invalid DPC trigger %#010x\n", status);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
190 | goto send_ost;
| ~~~~~~~~~~~~~~
191 | }
| ~
drivers/pci/pcie/edr.c:181:6: warning: variable 'err_dev' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
181 | if (!err_port->dpc_cap) {
| ^~~~~~~~~~~~~~~~~~
drivers/pci/pcie/edr.c:218:14: note: uninitialized use occurs here
218 | pci_dev_put(err_dev);
| ^~~~~~~
drivers/pci/pcie/edr.c:181:2: note: remove the 'if' if its condition is always false
181 | if (!err_port->dpc_cap) {
| ^~~~~~~~~~~~~~~~~~~~~~~~~
182 | pci_err(err_port, FW_BUG "This device doesn't support DPC\n");
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
183 | goto send_ost;
| ~~~~~~~~~~~~~~
184 | }
| ~
drivers/pci/pcie/edr.c:153:50: note: initialize the variable 'err_dev' to silence this warning
153 | struct pci_dev *pdev = data, *err_port, *err_dev;
| ^
| = NULL
3 warnings generated.
vim +188 drivers/pci/pcie/edr.c
ac1c8e35a3262d0 Kuppuswamy Sathyanarayanan 2020-03-23 150
ac1c8e35a3262d0 Kuppuswamy Sathyanarayanan 2020-03-23 151 static void edr_handle_event(acpi_handle handle, u32 event, void *data)
ac1c8e35a3262d0 Kuppuswamy Sathyanarayanan 2020-03-23 152 {
267102466d7b592 Shuai Xue 2025-09-17 153 struct pci_dev *pdev = data, *err_port, *err_dev;
ac1c8e35a3262d0 Kuppuswamy Sathyanarayanan 2020-03-23 154 pci_ers_result_t estate = PCI_ERS_RESULT_DISCONNECT;
ac1c8e35a3262d0 Kuppuswamy Sathyanarayanan 2020-03-23 155 u16 status;
ac1c8e35a3262d0 Kuppuswamy Sathyanarayanan 2020-03-23 156
ac1c8e35a3262d0 Kuppuswamy Sathyanarayanan 2020-03-23 157 if (event != ACPI_NOTIFY_DISCONNECT_RECOVER)
ac1c8e35a3262d0 Kuppuswamy Sathyanarayanan 2020-03-23 158 return;
ac1c8e35a3262d0 Kuppuswamy Sathyanarayanan 2020-03-23 159
774820b362b07b9 Bjorn Helgaas 2023-04-07 160 /*
774820b362b07b9 Bjorn Helgaas 2023-04-07 161 * pdev is a Root Port or Downstream Port that is still present and
774820b362b07b9 Bjorn Helgaas 2023-04-07 162 * has triggered a containment event, e.g., DPC, so its child
774820b362b07b9 Bjorn Helgaas 2023-04-07 163 * devices have been disconnected (ACPI r6.5, sec 5.6.6).
774820b362b07b9 Bjorn Helgaas 2023-04-07 164 */
af03958da0678c3 Kuppuswamy Sathyanarayanan 2020-04-15 165 pci_info(pdev, "EDR event received\n");
af03958da0678c3 Kuppuswamy Sathyanarayanan 2020-04-15 166
774820b362b07b9 Bjorn Helgaas 2023-04-07 167 /*
774820b362b07b9 Bjorn Helgaas 2023-04-07 168 * Locate the port that experienced the containment event. pdev
774820b362b07b9 Bjorn Helgaas 2023-04-07 169 * may be that port or a parent of it (PCI Firmware r3.3, sec
774820b362b07b9 Bjorn Helgaas 2023-04-07 170 * 4.6.13).
774820b362b07b9 Bjorn Helgaas 2023-04-07 171 */
a56b1e47845b946 Shuai Xue 2025-09-17 172 err_port = acpi_dpc_port_get(pdev);
a56b1e47845b946 Shuai Xue 2025-09-17 173 if (!err_port) {
ac1c8e35a3262d0 Kuppuswamy Sathyanarayanan 2020-03-23 174 pci_err(pdev, "Firmware failed to locate DPC port\n");
ac1c8e35a3262d0 Kuppuswamy Sathyanarayanan 2020-03-23 175 return;
ac1c8e35a3262d0 Kuppuswamy Sathyanarayanan 2020-03-23 176 }
ac1c8e35a3262d0 Kuppuswamy Sathyanarayanan 2020-03-23 177
a56b1e47845b946 Shuai Xue 2025-09-17 178 pci_dbg(pdev, "Reported EDR dev: %s\n", pci_name(err_port));
ac1c8e35a3262d0 Kuppuswamy Sathyanarayanan 2020-03-23 179
ac1c8e35a3262d0 Kuppuswamy Sathyanarayanan 2020-03-23 180 /* If port does not support DPC, just send the OST */
a56b1e47845b946 Shuai Xue 2025-09-17 181 if (!err_port->dpc_cap) {
a56b1e47845b946 Shuai Xue 2025-09-17 182 pci_err(err_port, FW_BUG "This device doesn't support DPC\n");
ac1c8e35a3262d0 Kuppuswamy Sathyanarayanan 2020-03-23 183 goto send_ost;
ac1c8e35a3262d0 Kuppuswamy Sathyanarayanan 2020-03-23 184 }
ac1c8e35a3262d0 Kuppuswamy Sathyanarayanan 2020-03-23 185
ac1c8e35a3262d0 Kuppuswamy Sathyanarayanan 2020-03-23 186 /* Check if there is a valid DPC trigger */
a56b1e47845b946 Shuai Xue 2025-09-17 187 pci_read_config_word(err_port, err_port->dpc_cap + PCI_EXP_DPC_STATUS, &status);
ac1c8e35a3262d0 Kuppuswamy Sathyanarayanan 2020-03-23 @188 if (!(status & PCI_EXP_DPC_STATUS_TRIGGER)) {
a56b1e47845b946 Shuai Xue 2025-09-17 189 pci_err(err_port, "Invalid DPC trigger %#010x\n", status);
ac1c8e35a3262d0 Kuppuswamy Sathyanarayanan 2020-03-23 190 goto send_ost;
ac1c8e35a3262d0 Kuppuswamy Sathyanarayanan 2020-03-23 191 }
ac1c8e35a3262d0 Kuppuswamy Sathyanarayanan 2020-03-23 192
267102466d7b592 Shuai Xue 2025-09-17 193 err_dev = dpc_process_error(err_port);
a56b1e47845b946 Shuai Xue 2025-09-17 194 pci_aer_raw_clear_status(err_port);
ac1c8e35a3262d0 Kuppuswamy Sathyanarayanan 2020-03-23 195
ac1c8e35a3262d0 Kuppuswamy Sathyanarayanan 2020-03-23 196 /*
ac1c8e35a3262d0 Kuppuswamy Sathyanarayanan 2020-03-23 197 * Irrespective of whether the DPC event is triggered by ERR_FATAL
ac1c8e35a3262d0 Kuppuswamy Sathyanarayanan 2020-03-23 198 * or ERR_NONFATAL, since the link is already down, use the FATAL
ac1c8e35a3262d0 Kuppuswamy Sathyanarayanan 2020-03-23 199 * error recovery path for both cases.
ac1c8e35a3262d0 Kuppuswamy Sathyanarayanan 2020-03-23 200 */
267102466d7b592 Shuai Xue 2025-09-17 201 estate = pcie_do_recovery(err_dev, pci_channel_io_frozen, dpc_reset_link);
ac1c8e35a3262d0 Kuppuswamy Sathyanarayanan 2020-03-23 202
ac1c8e35a3262d0 Kuppuswamy Sathyanarayanan 2020-03-23 203 send_ost:
ac1c8e35a3262d0 Kuppuswamy Sathyanarayanan 2020-03-23 204
ac1c8e35a3262d0 Kuppuswamy Sathyanarayanan 2020-03-23 205 /*
ac1c8e35a3262d0 Kuppuswamy Sathyanarayanan 2020-03-23 206 * If recovery is successful, send _OST(0xF, BDF << 16 | 0x80)
ac1c8e35a3262d0 Kuppuswamy Sathyanarayanan 2020-03-23 207 * to firmware. If not successful, send _OST(0xF, BDF << 16 | 0x81).
ac1c8e35a3262d0 Kuppuswamy Sathyanarayanan 2020-03-23 208 */
ac1c8e35a3262d0 Kuppuswamy Sathyanarayanan 2020-03-23 209 if (estate == PCI_ERS_RESULT_RECOVERED) {
a56b1e47845b946 Shuai Xue 2025-09-17 210 pci_dbg(err_port, "DPC port successfully recovered\n");
a56b1e47845b946 Shuai Xue 2025-09-17 211 pcie_clear_device_status(err_port);
a56b1e47845b946 Shuai Xue 2025-09-17 212 acpi_send_edr_status(pdev, err_port, EDR_OST_SUCCESS);
ac1c8e35a3262d0 Kuppuswamy Sathyanarayanan 2020-03-23 213 } else {
a56b1e47845b946 Shuai Xue 2025-09-17 214 pci_dbg(err_port, "DPC port recovery failed\n");
a56b1e47845b946 Shuai Xue 2025-09-17 215 acpi_send_edr_status(pdev, err_port, EDR_OST_FAILED);
ac1c8e35a3262d0 Kuppuswamy Sathyanarayanan 2020-03-23 216 }
ac1c8e35a3262d0 Kuppuswamy Sathyanarayanan 2020-03-23 217
267102466d7b592 Shuai Xue 2025-09-17 218 pci_dev_put(err_dev);
a56b1e47845b946 Shuai Xue 2025-09-17 219 pci_dev_put(err_port);
ac1c8e35a3262d0 Kuppuswamy Sathyanarayanan 2020-03-23 220 }
ac1c8e35a3262d0 Kuppuswamy Sathyanarayanan 2020-03-23 221
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists