linux-kernel - Re: [PATCH v14 02/10] power: reset: reboot-mode: Add device tree node-based registration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <wsig6dm7jbnx2pzt5l3uhhgywsa4jsdyunmd5aqn43bbciqiov@4y6mnd25pbeg>
Date: Thu, 18 Sep 2025 00:32:24 +0200
From: Sebastian Reichel <sebastian.reichel@...labora.com>
To: Shivendra Pratap <shivendra.pratap@....qualcomm.com>
Cc: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>, 
	Bjorn Andersson <andersson@...nel.org>, Rob Herring <robh@...nel.org>, 
	Sudeep Holla <sudeep.holla@....com>, Souvik Chakravarty <Souvik.Chakravarty@....com>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Andy Yan <andy.yan@...k-chips.com>, Mark Rutland <mark.rutland@....com>, 
	Lorenzo Pieralisi <lpieralisi@...nel.org>, Arnd Bergmann <arnd@...db.de>, 
	Konrad Dybcio <konradybcio@...nel.org>, cros-qcom-dts-watchers@...omium.org, 
	Vinod Koul <vkoul@...nel.org>, Catalin Marinas <catalin.marinas@....com>, 
	Will Deacon <will@...nel.org>, Florian Fainelli <florian.fainelli@...adcom.com>, 
	Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>, Mukesh Ojha <mukesh.ojha@....qualcomm.com>, 
	Stephen Boyd <swboyd@...omium.org>, Andre Draszik <andre.draszik@...aro.org>, 
	linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-arm-msm@...r.kernel.org, 
	Elliot Berman <quic_eberman@...cinc.com>, Srinivas Kandagatla <srini@...nel.org>
Subject: Re: [PATCH v14 02/10] power: reset: reboot-mode: Add device tree
 node-based registration

Hi,

On Wed, Sep 17, 2025 at 09:59:44PM +0530, Shivendra Pratap wrote:
> On 9/17/2025 12:18 AM, Sebastian Reichel wrote:
> > On Fri, Aug 15, 2025 at 08:05:07PM +0530, Shivendra Pratap wrote:
> >> The reboot-mode driver does not have a strict requirement for
> >> device-based registration. It primarily uses the device's of_node
> >> to read mode-<cmd> properties and the device pointer for logging.
> >>
> >> Remove the dependency on struct device and introduce support for
> >> Device Tree (DT) node-based registration. This enables drivers
> >> that are not associated with a struct device to leverage the
> >> reboot-mode framework.
> >>
> >> Signed-off-by: Shivendra Pratap <shivendra.pratap@....qualcomm.com>
> >> ---
> > 
> > Please use fwnode instead of device_node, so that the same thing
> > can be used with non DT setups, if that becomes necessary. Otherwise
> > LGTM.
> 
> To be more clear on this, have one question: the current unmodified
> design of reboot-mode is dt based:
> 
> struct device_node *np = reboot->dev->of_node;
> and then parses the node using for_each_property_of_node(np, prop).
> 
> We want to refactor reboot-mode to support non-DT setups by adding
> support for fwnode-based approach (struct fwnode_handle *fwnode)?
> 
> Can you please explain a bit? Some more details would be helpful to
> make the change.

It's fine to keep using of_node internally. But the external API
(include/linux/reboot-mode.h) should use fwnode. Just like the
current external API is not DT specific as it just gets a struct
device. This keeps the external API somewhat ready for non-DT users
and avoids having to change all API users again in the future.

Greetings,

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)