linux-kernel - Re: [PATCH] ASoC: stm32: sai: manage context in set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87ms6taph0.wl-kuninori.morimoto.gx@renesas.com>
Date: Wed, 17 Sep 2025 00:32:11 +0000
From: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To: Olivier Moysan <olivier.moysan@...s.st.com>
Cc: Arnaud Pouliquen
	<arnaud.pouliquen@...s.st.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	"Mark\
 Brown" <broonie@...nel.org>,
	Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai
	<tiwai@...e.com>,
	Maxime Coquelin <mcoquelin.stm32@...il.com>,
	"Alexandre\
 Torgue" <alexandre.torgue@...s.st.com>,
	<linux-sound@...r.kernel.org>,
	<linux-stm32@...md-mailman.stormreply.com>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ASoC: stm32: sai: manage context in set_sysclk callback


Hi Olivier

Thank you for your feedback

> Here is feedback regarding commit 5725bce709db1c001140d79398581e067e28c031
> ASoC: simple-card-utils: Unify clock direction by clk_direction
(snip)
> To accommodate the change introduced by this commit, I added the property
> "system-clock-direction-out" in the SAI device tree node.
(snip)
> * Before the change:
> - Initialization:
> simple_init_dai() -> set_sysclk(id=0, freq=sai_ck freq, dir=out)
> 	Calls clk_set_rate_exclusive()
> simple_util_shutdown() -> set_sysclk(id=0, freq=0, dir=out)
> 	Calls clk_rate_exclusive_put() (releases the mclk clock)

Here, about "Before the change". Does this "change" mean "before adding
system-clock-direction-out" or "before commit 5725bce709db1..." ?

> * After the change:
> - Initialization:
> simple_init_dai() -> set_sysclk(id=0, freq=sai_ck freq, dir=out)
> 	Calls clk_set_rate_exclusive()
> simple_util_shutdown() -> set_sysclk(id=0, freq=0, dir=in)
> 	clk_rate_exclusive_put() NOT called (mclk clock is not released)

Hmm...
If it was latest kernel, and if you added "system-clock-direction-out" in DT,
dir should be "out" in my understanding. dir=in means it doesn't have
"system-clock-direction-out".

And, dir will not be changed (out/in) in init / shutdown.
Are these same DAI ? Both "struct snd_soc_dai" and "struct simple_util_dai"
have "*name". Could you please double-check it ?

Thank you for your help !!

Best regards
---
Kuninori Morimoto