lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2025091705-murky-sage-465f@gregkh>
Date: Wed, 17 Sep 2025 07:52:01 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Akiyoshi Kurita <weibu@...admin.org>
Cc: linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: xmit: fix grammar in comment

On Wed, Sep 17, 2025 at 02:39:44PM +0900, Akiyoshi Kurita wrote:
> Fix 'number of page' -> 'number of pages' in a comment.
> 
> Signed-off-by: Akiyoshi Kurita <weibu@...admin.org>
> ---
>  drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
> index 842e19b53421..7ba8981f4652 100644
> --- a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
> +++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
> @@ -76,7 +76,7 @@ static s32 rtl8723_dequeue_writeport(struct adapter *padapter)
>  	/*  check if hardware tx fifo page is enough */
>  	if (!rtw_hal_sdio_query_tx_freepage(pri_padapter, PageIdx, pxmitbuf->pg_num)) {
>  		if (!bUpdatePageNum) {
> -			/*  Total number of page is NOT available, so update current FIFO status */
> +			/*  Total number of pages is NOT available, so update current FIFO status */

As "pages" is now plural, shouldn't "is" become "are"?

Also, you can drop the extra leading space in the comment.

thanks,

greg "english grammer is rough" k-h

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ