linux-kernel - [PATCH v2 1/1] media: atomisp: Avoid memory leaks in ia_css_pipe_create_cas_scaler_desc_single

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20250917004240.506794-1-i.abramov@mt-integration.ru>
Date: Wed, 17 Sep 2025 03:42:36 +0300
From: Ivan Abramov <i.abramov@...integration.ru>
To: Andy Shevchenko <andy@...nel.org>
CC: Ivan Abramov <i.abramov@...integration.ru>, Hans de Goede
	<hansg@...nel.org>, Mauro Carvalho Chehab <mchehab@...nel.org>, Sakari Ailus
	<sakari.ailus@...ux.intel.com>, Greg Kroah-Hartman
	<gregkh@...uxfoundation.org>, Colin Ian King <colin.i.king@...il.com>, Alan
 Cox <alan@...ux.intel.com>, <linux-media@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <linux-staging@...ts.linux.dev>,
	<lvc-project@...uxtesting.org>
Subject: [PATCH v2 1/1] media: atomisp: Avoid memory leaks in ia_css_pipe_create_cas_scaler_desc_single_output()

If any of the memory allocations for descr struct members fail, goto ERR is
executed, and none of the previously allocated memory is freed, which leads
to leaking memory.

Fix this by freeing memory at the end of the function in case of an
non-NULL err.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: a49d25364dfb ("staging/atomisp: Add support for the Intel IPU v2")
Signed-off-by: Ivan Abramov <i.abramov@...integration.ru>
---
v2: Fix code formatting.
 drivers/staging/media/atomisp/pci/sh_css.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/staging/media/atomisp/pci/sh_css.c b/drivers/staging/media/atomisp/pci/sh_css.c
index 73bd87f43a8c..d50bc81a59dc 100644
--- a/drivers/staging/media/atomisp/pci/sh_css.c
+++ b/drivers/staging/media/atomisp/pci/sh_css.c
@@ -5907,6 +5907,10 @@ static int ia_css_pipe_create_cas_scaler_desc_single_output(
 	ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE_PRIVATE,
 			    "ia_css_pipe_create_cas_scaler_desc() leave, err=%d\n",
 			    err);
+
+	if (err)
+		ia_css_pipe_destroy_cas_scaler_desc(descr);
+
 	return err;
 }
 
-- 
2.39.5