linux-kernel - Re: [PATCH v3 1/2] sched: Create architecture specific sched domain distances

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <04b1ec0a-414a-4f28-9804-4a6d2c95b10f@amd.com>
Date: Wed, 17 Sep 2025 12:15:07 +0530
From: K Prateek Nayak <kprateek.nayak@....com>
To: Tim Chen <tim.c.chen@...ux.intel.com>, Peter Zijlstra
	<peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>
CC: Juri Lelli <juri.lelli@...hat.com>, Dietmar Eggemann
	<dietmar.eggemann@....com>, Ben Segall <bsegall@...gle.com>, Mel Gorman
	<mgorman@...e.de>, Valentin Schneider <vschneid@...hat.com>, Tim Chen
	<tim.c.chen@...el.com>, Vincent Guittot <vincent.guittot@...aro.org>, "Libo
 Chen" <libo.chen@...cle.com>, Abel Wu <wuyun.abel@...edance.com>, Len Brown
	<len.brown@...el.com>, <linux-kernel@...r.kernel.org>, Chen Yu
	<yu.c.chen@...el.com>, "Gautham R . Shenoy" <gautham.shenoy@....com>, "Zhao
 Liu" <zhao1.liu@...el.com>, Vinicius Costa Gomes <vinicius.gomes@...el.com>,
	Arjan Van De Ven <arjan.van.de.ven@...el.com>
Subject: Re: [PATCH v3 1/2] sched: Create architecture specific sched domain
 distances

Hello Tim,

On 9/15/2025 10:14 PM, Tim Chen wrote:
> On Fri, 2025-09-12 at 08:53 +0530, K Prateek Nayak wrote:
>> Hello Tim,
>>
>> On 9/12/2025 12:00 AM, Tim Chen wrote:
>>> +static int sched_record_numa_dist(int offline_node, int (*n_dist)(int, int),
>>> +		int **dist, int *levels)
>>> +
>> nit. Is the blank line above intentional?
>>
>> Also personally I prefer breaking the two lines above as:
>>
>> static int
>> sched_record_numa_dist(int offline_node, int (*n_dist)(int, int), int **dist, int *levels)
> That would exceed 80 characters.  So we would still need to move some parameters to a different
> line to keep within the limit.

Well build_balance_mask() in the same file follows this pattern and
exceeds 80 characters. Maybe it is alright as long as is under 100
characters :)

-- 
Thanks and Regards,
Prateek