linux-kernel - Re: [Intel-wired-lan] [PATCH iwl-net] libie: fix string names for AQ error codes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <329bdb90-578b-4fba-97fd-7000baa281e6@molgen.mpg.de>
Date: Wed, 17 Sep 2025 08:49:44 +0200
From: Paul Menzel <pmenzel@...gen.mpg.de>
To: Jacob Keller <jacob.e.keller@...el.com>
Cc: Tony Nguyen <anthony.l.nguyen@...el.com>,
 Przemek Kitszel <przemyslaw.kitszel@...el.com>,
 Alexander Lobakin <aleksander.lobakin@...el.com>,
 Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>,
 intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [Intel-wired-lan] [PATCH iwl-net] libie: fix string names for AQ
 error codes

Dear Jacob,

Thank you for your patch.

Am 16.09.25 um 22:09 schrieb Jacob Keller:
> The LIBIE_AQ_STR macro() introduced by commit 5feaa7a07b85 ("libie: add
> adminq helper for converting err to str") is used in order to generate
> strings for printing human readable error codes. Its definition is missing
> the separating underscore ('_') character which makes the resulting strings
> difficult to read. Additionally, the string won't match the source code,
> preventing search tools from working properly.
> 
> Add the missing underscore character, fixing the error string names.
> 
> Signed-off-by: Jacob Keller <jacob.e.keller@...el.com>
> Fixes: 5feaa7a07b85 ("libie: add adminq helper for converting err to str")
> ---
> I found this recently while reviewing the libie code. I believe this
> warrants a net fix because it is both simple, and because users may attempt
> to pass printed error codes into search tools like grep, and will be unable
> to locate the error values without manually adding the missing '_'.

As always, great commit message! Thank you.

> ---
>   drivers/net/ethernet/intel/libie/adminq.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/intel/libie/adminq.c b/drivers/net/ethernet/intel/libie/adminq.c
> index 55356548e3f0..7b4ff479e7e5 100644
> --- a/drivers/net/ethernet/intel/libie/adminq.c
> +++ b/drivers/net/ethernet/intel/libie/adminq.c
> @@ -6,7 +6,7 @@
>   
>   static const char * const libie_aq_str_arr[] = {
>   #define LIBIE_AQ_STR(x)					\
> -	[LIBIE_AQ_RC_##x]	= "LIBIE_AQ_RC" #x
> +	[LIBIE_AQ_RC_##x]	= "LIBIE_AQ_RC_" #x
>   	LIBIE_AQ_STR(OK),
>   	LIBIE_AQ_STR(EPERM),
>   	LIBIE_AQ_STR(ENOENT),

Reviewed-by: Paul Menzel <pmenzel@...gen.mpg.de>

Kind regards,

Paul