linux-kernel - Re: [PATCH v3 03/11] cxl/region: Rename misleading variable name @hpa to @range

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aMptCmrATwzBH6kA@rric.localdomain>
Date: Wed, 17 Sep 2025 10:10:50 +0200
From: Robert Richter <rrichter@....com>
To: Jonathan Cameron <jonathan.cameron@...wei.com>
Cc: Dave Jiang <dave.jiang@...el.com>,
	Alison Schofield <alison.schofield@...el.com>,
	Vishal Verma <vishal.l.verma@...el.com>,
	Ira Weiny <ira.weiny@...el.com>,
	Dan Williams <dan.j.williams@...el.com>,
	Davidlohr Bueso <dave@...olabs.net>, linux-cxl@...r.kernel.org,
	linux-kernel@...r.kernel.org, Gregory Price <gourry@...rry.net>,
	"Fabio M. De Francesco" <fabio.m.de.francesco@...ux.intel.com>,
	Terry Bowman <terry.bowman@....com>,
	Joshua Hahn <joshua.hahnjy@...il.com>
Subject: Re: [PATCH v3 03/11] cxl/region: Rename misleading variable name
 @hpa to @range

On 15.09.25 11:25:55, Jonathan Cameron wrote:
> On Mon, 15 Sep 2025 09:27:36 +0200
> Robert Richter <rrichter@....com> wrote:
> 
> > On 12.09.25 10:33:30, Dave Jiang wrote:
> > > 
> > > 
> > > On 9/12/25 7:45 AM, Robert Richter wrote:  
> > > > @hpa is actually a @range, rename variables accordingly.  
> > > 
> > > it's a range of HPA right? May as well call it 'hpa_range' to distinguish from 'dpa_range' or 'spa_range'  
> > 
> > To me this is ok as it is locally used only in the functions. I used
> > the short version to not hit the 80 char line limit in some of the
> > statements for readability. Range is most of the time HPA unless for
> > special cases, which use a prefix then. It also becomes clear viewed
> > in context, e.g.
> > 
> > 	 range = &cxld->hpa_range;
> > 
> > Thus, I rather would like to not change that.
> 
> I'm with Dave on this one.  Better to have some slightly long lines
> and avoid any potential confusion.

Ok, thanks.

-Robert