linux-kernel - Re: [PATCH v1 2/4] perf test: Don't leak workload gopipe in PERF_RECORD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aMoJkR_jtzrGCLKI@x1>
Date: Tue, 16 Sep 2025 22:06:25 -0300
From: Arnaldo Carvalho de Melo <acme@...nel.org>
To: Ian Rogers <irogers@...gle.com>
Cc: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>,
	Namhyung Kim <namhyung@...nel.org>,
	Mark Rutland <mark.rutland@....com>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Jiri Olsa <jolsa@...nel.org>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Kan Liang <kan.liang@...ux.intel.com>,
	Chun-Tse Shao <ctshao@...gle.com>,
	James Clark <james.clark@...aro.org>,
	Howard Chu <howardchu95@...il.com>, linux-kernel@...r.kernel.org,
	linux-perf-users@...r.kernel.org
Subject: Re: [PATCH v1 2/4] perf test: Don't leak workload gopipe in
 PERF_RECORD_*

On Tue, Sep 16, 2025 at 12:08:58PM -0700, Ian Rogers wrote:
> On Tue, Sep 16, 2025 at 12:04 PM Arnaldo Carvalho de Melo <acme@...nel.org> wrote:
> > On Thu, Aug 21, 2025 at 03:18:32PM -0700, Ian Rogers wrote:
> > > The test starts a workload and then opens events. If the events fail
> > > to open, for example because of perf_event_paranoid, the gopipe of the
> > > workload is leaked and the file descriptor leak check fails when the
> > > test exits. To avoid this cancel the workload when opening the events
> > > fails.

> > > Before:
> > > ```
> > > $ perf test -vv 7
> > >   7: PERF_RECORD_* events & perf_sample fields:
> > > --- start ---

> > ⬢ [acme@...lbx perf-tools-next]$ patch -p1 < b
> > patching file tools/perf/tests/perf-record.c
> > Hunk #1 succeeded at 130 (offset 15 lines).
> > Hunk #2 succeeded at 142 with fuzz 1 (offset 15 lines).
> > Hunk #3 succeeded at 154 (offset 15 lines).
> > Hunk #4 succeeded at 167 (offset 15 lines).
> > ⬢ [acme@...lbx perf-tools-next]$
> > ⬢ [acme@...lbx perf-tools-next]$ git log --oneline -5 tools/perf/tests/perf-record.c
> > 576bd7a8c90c48e9 (x1/perf-tools-next, x1/HEAD, five/perf-tools-next, five/HEAD) perf tests record: Update testcase to fix usage of affinity for machines with #CPUs > 1K
> > b4c658d4d63d6149 perf target: Remove uid from target
> > dc6d2bc2d893a878 perf sample: Make user_regs and intr_regs optional
> > fd8d5a3b076c033f perf tests: Add missing event.h include
> > 9823147da6c893d9 perf tools: Move 'struct perf_sample' to a separate header file to disentangle headers
> > ⬢ [acme@...lbx perf-tools-next]$

> > Can you please check that it is still ok?

> > I processed the first in the series and now I'm going thru the other
> > two.
 
> Thanks Arnaldo! I'm not seeing the patch on:
> https://web.git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/log/?h=tmp.perf-tools-next

Sorry, I thought I had pushed it earlier, should be there now.

> I'm happy to check.

Thanks!

- Arnaldo