linux-kernel - Re: [PATCH 1/7 5.10.y] tracing: Define the is_signed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025091717-snowflake-subtract-40f7@gregkh>
Date: Wed, 17 Sep 2025 10:40:55 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Eliav Farber <farbere@...zon.com>
Cc: luc.vanoostenryck@...il.com, rostedt@...dmis.org, mingo@...hat.com,
	akpm@...ux-foundation.org, sj@...nel.org, David.Laight@...lab.com,
	Jason@...c4.com, andriy.shevchenko@...ux.intel.com,
	bvanassche@....org, keescook@...omium.org,
	linux-sparse@...r.kernel.org, linux-kernel@...r.kernel.org,
	jonnyc@...zon.com, stable@...r.kernel.org,
	Rasmus Villemoes <linux@...musvillemoes.dk>
Subject: Re: [PATCH 1/7 5.10.y] tracing: Define the is_signed_type() macro
 once

On Tue, Sep 16, 2025 at 09:22:53PM +0000, Eliav Farber wrote:
> From: Bart Van Assche <bvanassche@....org>
> 
> commit 92d23c6e94157739b997cacce151586a0d07bb8a upstream.

This is only in 6.1, and not other trees, why is it needed here?

> 
> There are two definitions of the is_signed_type() macro: one in
> <linux/overflow.h> and a second definition in <linux/trace_events.h>.
> 
> As suggested by Linus, move the definition of the is_signed_type() macro
> into the <linux/compiler.h> header file.  Change the definition of the
> is_signed_type() macro to make sure that it does not trigger any sparse
> warnings with future versions of sparse for bitwise types.
> 
> Link: https://lore.kernel.org/all/CAHk-=whjH6p+qzwUdx5SOVVHjS3WvzJQr6mDUwhEyTf6pJWzaQ@mail.gmail.com/
> Link: https://lore.kernel.org/all/CAHk-=wjQGnVfb4jehFR0XyZikdQvCZouE96xR_nnf5kqaM5qqQ@mail.gmail.com/
> Cc: Rasmus Villemoes <linux@...musvillemoes.dk>
> Cc: Steven Rostedt <rostedt@...dmis.org>
> Acked-by: Kees Cook <keescook@...omium.org>
> Signed-off-by: Bart Van Assche <bvanassche@....org>
> Signed-off-by: Linus Torvalds <torvalds@...ux-foundation.org>
> (cherry picked from commit a49a64b5bf195381c09202c524f0f84b5f3e816f)

This is not a valid git id in the tree at all.

greg k-h