linux-kernel - Re: [PATCH v6 2/2] iio: ABI: document accelerometer event attributes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aMp1orvA-SSSZeN2@smile.fi.intel.com>
Date: Wed, 17 Sep 2025 11:47:30 +0300
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Gustavo Silva <gustavograzs@...il.com>
Cc: Alex Lanzano <lanzano.alex@...il.com>,
	Jonathan Cameron <jic23@...nel.org>,
	David Lechner <dlechner@...libre.com>,
	Nuno Sá <nuno.sa@...log.com>,
	Andy Shevchenko <andy@...nel.org>, linux-iio@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 2/2] iio: ABI: document accelerometer event attributes

On Tue, Sep 16, 2025 at 08:38:24PM -0300, Gustavo Silva wrote:
> Add ABI documentation for accelerometer event-related sysfs attributes
> exposed by the bmi270 driver. These include threshold, period, and
> enable controls for adaptive magnitude (any-motion) and rate of change
> (no-motion) event detection.

...

> What:		/sys/.../iio:deviceX/events/in_accel_y_roc_rising_en

>  What:		/sys/.../iio:deviceX/events/in_accel_y_roc_falling_en
>  What:		/sys/.../iio:deviceX/events/in_accel_z_roc_rising_en
>  What:		/sys/.../iio:deviceX/events/in_accel_z_roc_falling_en
> +What:		/sys/.../iio:deviceX/events/in_accel_x&y&z_roc_rising_en
>  What:		/sys/.../iio:deviceX/events/in_anglvel_x_roc_rising_en
>  What:		/sys/.../iio:deviceX/events/in_anglvel_x_roc_falling_en
>  What:		/sys/.../iio:deviceX/events/in_anglvel_y_roc_rising_en

> What:		/sys/.../events/in_accel_y_raw_thresh_rising_value

>  What:		/sys/.../events/in_accel_y_raw_thresh_falling_value
>  What:		/sys/.../events/in_accel_z_raw_thresh_rising_value
>  What:		/sys/.../events/in_accel_z_raw_thresh_falling_value
> +What:		/sys/.../events/in_accel_mag_adaptive_rising_value
>  What:		/sys/.../events/in_anglvel_x_raw_thresh_rising_value
>  What:		/sys/.../events/in_anglvel_x_raw_thresh_falling_value
>  What:		/sys/.../events/in_anglvel_y_raw_thresh_rising_value

> +What:		/sys/.../events/in_accel_roc_rising_value
>  What:		/sys/.../events/in_accel_x_raw_roc_rising_value
>  What:		/sys/.../events/in_accel_x_raw_roc_falling_value
>  What:		/sys/.../events/in_accel_y_raw_roc_rising_value

>  What:		/sys/.../events/in_accel_x_thresh_rising_period
>  What:		/sys/.../events/in_accel_x_thresh_falling_period
> +What:		/sys/.../events/in_accel_roc_rising_period
>  What:		/sys/.../events/in_accel_x_roc_rising_period
>  What:		/sys/.../events/in_accel_x_roc_falling_period
>  What:		/sys/.../events/in_accel_y_thresh_rising_period

With the given context (above and below) I'm not sure this is the best place of
putting an attribute in the list. Perhaps something below will not disrupt the
xyz structure (like mag cases)?

> What:		/sys/.../events/in_accel_z_thresh_rising_period

>  What:		/sys/.../events/in_accel_z_thresh_falling_period
>  What:		/sys/.../events/in_accel_z_roc_rising_period
>  What:		/sys/.../events/in_accel_z_roc_falling_period
> +What:		/sys/.../events/in_accel_mag_adaptive_rising_period
>  What:		/sys/.../events/in_anglvel_x_thresh_rising_period
>  What:		/sys/.../events/in_anglvel_x_thresh_falling_period
>  What:		/sys/.../events/in_anglvel_x_roc_rising_period

-- 
With Best Regards,
Andy Shevchenko