linux-kernel - Re: [PATCH v4 1/5] printk: nbcon: Export console_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aMp4BrEpqXOW9nam@pathway.suse.cz>
Date: Wed, 17 Sep 2025 10:57:42 +0200
From: Petr Mladek <pmladek@...e.com>
To: Marcos Paulo de Souza <mpdesouza@...e.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	John Ogness <john.ogness@...utronix.de>,
	Sergey Senozhatsky <senozhatsky@...omium.org>,
	Jason Wessel <jason.wessel@...driver.com>,
	Daniel Thompson <danielt@...nel.org>,
	Douglas Anderson <dianders@...omium.org>,
	linux-kernel@...r.kernel.org, kgdb-bugreport@...ts.sourceforge.net
Subject: Re: [PATCH v4 1/5] printk: nbcon: Export console_is_usable

On Mon 2025-09-15 08:20:30, Marcos Paulo de Souza wrote:
> The helper will be used on KDB code in the next commits.
> 
> Reviewed-by: Petr Mladek <pmladek@...e.com>
> Signed-off-by: Marcos Paulo de Souza <mpdesouza@...e.com>

Nit :-)

The ordering of the tags is important. It defines the timeline of
the related actions.

The above ordering might be understood as that Petr reviewed
an older version of patch. But it was later modified by Marcos.

The expected ordering is:

Signed-off-by: Marcos Paulo de Souza <mpdesouza@...e.com>
Reviewed-by: Petr Mladek <pmladek@...e.com>

It means that Macros developed a patch and Petr reviewed it.
The patch was not longer modified.

Note the Reviewed-by tag might be preserved even when Marcos
later did some cosmetic changes, e.g. fixed a typo, formatting,
or rebased.

Best Regards,
Petr

PS: There is no need to send v5 just because of this. I could fix
    it when committing the patch...