linux-kernel - Re: [PATCH net-next] ppp: enable TX scatter-gather

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALW65jZaDtchy1FFttNH9jMo--YSoZMsb8=HE72i=ZdnNP-akw@mail.gmail.com>
Date: Wed, 17 Sep 2025 19:00:16 +0800
From: Qingfang Deng <dqfext@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, linux-ppp@...r.kernel.org, 
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Felix Fietkau <nbd@....name>
Subject: Re: [PATCH net-next] ppp: enable TX scatter-gather

On Tue, Sep 16, 2025 at 10:57 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Tue, 16 Sep 2025 10:57:49 +0800 Qingfang Deng wrote:
> > Can I modify dev->features directly under the spin lock (without
> > .ndo_fix_features) ?
>
> Hm, I'm not aware of a reason not to. You definitely need to hold
> rtnl_lock, and call netdev_update_features() after.

Will the modification race against __netdev_update_features(), where
dev->features is assigned a new value?