linux-kernel - Re: [PATCH v4 2/3] sched: make migrate_enable/migrate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2383379.ElGaqSPkdT@7940hx>
Date: Wed, 17 Sep 2025 09:30:50 +0800
From: Menglong Dong <menglong.dong@...ux.dev>
To: Alexei Starovoitov <alexei.starovoitov@...il.com>
Cc: Peter Zijlstra <peterz@...radead.org>,
 Alexei Starovoitov <ast@...nel.org>, Ingo Molnar <mingo@...hat.com>,
 Juri Lelli <juri.lelli@...hat.com>,
 Vincent Guittot <vincent.guittot@...aro.org>,
 Dietmar Eggemann <dietmar.eggemann@....com>,
 Steven Rostedt <rostedt@...dmis.org>, Benjamin Segall <bsegall@...gle.com>,
 Mel Gorman <mgorman@...e.de>, Valentin Schneider <vschneid@...hat.com>,
 Daniel Borkmann <daniel@...earbox.net>,
 John Fastabend <john.fastabend@...il.com>,
 Andrii Nakryiko <andrii@...nel.org>, Martin KaFai Lau <martin.lau@...ux.dev>,
 Eduard <eddyz87@...il.com>, Song Liu <song@...nel.org>,
 Yonghong Song <yonghong.song@...ux.dev>, KP Singh <kpsingh@...nel.org>,
 Stanislav Fomichev <sdf@...ichev.me>, Hao Luo <haoluo@...gle.com>,
 Jiri Olsa <jolsa@...nel.org>, tzimmermann@...e.de, simona.vetter@...ll.ch,
 Jani Nikula <jani.nikula@...el.com>, LKML <linux-kernel@...r.kernel.org>,
 bpf <bpf@...r.kernel.org>
Subject: Re: [PATCH v4 2/3] sched: make migrate_enable/migrate_disable inline

On 2025/9/17 09:29 Alexei Starovoitov <alexei.starovoitov@...il.com> write:
> On Tue, Sep 16, 2025 at 6:26 PM Menglong Dong <menglong.dong@...ux.dev> wrote:
> >
> > On 2025/9/16 19:07 Peter Zijlstra <peterz@...radead.org> write:
> > > On Thu, Aug 28, 2025 at 02:03:53PM +0800, Menglong Dong wrote:
> > >
> > > > +/* The "struct rq" is not available here, so we can't access the
> > > > + * "runqueues" with this_cpu_ptr(), as the compilation will fail in
> > > > + * this_cpu_ptr() -> raw_cpu_ptr() -> __verify_pcpu_ptr():
> > > > + *   typeof((ptr) + 0)
> > > > + *
> > > > + * So use arch_raw_cpu_ptr()/PERCPU_PTR() directly here.
> > > > + */
> > >
> > > Please fix broken comment style while you fix that compile error.
> >
> > It's a little embarrassing. The compile error is caused by the commit
> > 1b93c03fb319 ("rcu: add rcu_read_lock_dont_migrate()") in bpf-next tree,
> > which uses migrate_enable/migrate_disable in include/linux/rcupdate.h
> > but include the <linux/preempt.h>.
> >
> > I can fix it by replace the linux/preempt.h with linux/sched.h, but should
> > I fix it in this series? I mean, the commit 1b93c03fb319 doesn't exist in
> > the tip for now :/
> 
> If it's just a different include then go for it.
> Make sure there are no nasty build issues during the merge window.

OK!

>