linux-kernel - Re: [PATCH 1/2] accel/qaic: Replace kzalloc + copy_from_user with memdup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b1ef69f5-e485-4e05-b9ca-6ea73200455a@linux.intel.com>
Date: Wed, 17 Sep 2025 14:54:25 +0200
From: Karol Wachowski <karol.wachowski@...ux.intel.com>
To: Thorsten Blum <thorsten.blum@...ux.dev>,
 Jeff Hugo <jeff.hugo@....qualcomm.com>,
 Carl Vanderlip <carl.vanderlip@....qualcomm.com>,
 Oded Gabbay <ogabbay@...nel.org>
Cc: linux-arm-msm@...r.kernel.org, dri-devel@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] accel/qaic: Replace kzalloc + copy_from_user with
 memdup_user

Reviewed-by: Karol Wachowski <karol.wachowski@...ux.intel.com>

On 9/17/2025 2:48 PM, Thorsten Blum wrote:
> Replace kzalloc() followed by copy_from_user() with memdup_user() to
> improve and simplify qaic_attach_slice_bo_ioctl().
>
> No functional changes intended.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>
> ---
>  drivers/accel/qaic/qaic_data.c | 13 ++++---------
>  1 file changed, 4 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/accel/qaic/qaic_data.c b/drivers/accel/qaic/qaic_data.c
> index 797289e9d780..202bdca58847 100644
> --- a/drivers/accel/qaic/qaic_data.c
> +++ b/drivers/accel/qaic/qaic_data.c
> @@ -18,6 +18,7 @@
>  #include <linux/scatterlist.h>
>  #include <linux/spinlock.h>
>  #include <linux/srcu.h>
> +#include <linux/string.h>
>  #include <linux/types.h>
>  #include <linux/uaccess.h>
>  #include <linux/wait.h>
> @@ -984,18 +985,12 @@ int qaic_attach_slice_bo_ioctl(struct drm_device *dev, void *data, struct drm_fi
>  
>  	user_data = u64_to_user_ptr(args->data);
>  
> -	slice_ent = kzalloc(arg_size, GFP_KERNEL);
> -	if (!slice_ent) {
> -		ret = -EINVAL;
> +	slice_ent = memdup_user(user_data, arg_size);
> +	if (IS_ERR(slice_ent)) {
> +		ret = PTR_ERR(slice_ent);
>  		goto unlock_dev_srcu;
>  	}
>  
> -	ret = copy_from_user(slice_ent, user_data, arg_size);
> -	if (ret) {
> -		ret = -EFAULT;
> -		goto free_slice_ent;
> -	}
> -
>  	obj = drm_gem_object_lookup(file_priv, args->hdr.handle);
>  	if (!obj) {
>  		ret = -ENOENT;