linux-kernel - Re: [PATCH RFC] dt-bindings: thunderbolt: Add Qualcomm USB4 Host Router

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250918152322.GK2912318@black.igk.intel.com>
Date: Thu, 18 Sep 2025 17:23:22 +0200
From: Mika Westerberg <mika.westerberg@...ux.intel.com>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
Cc: Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Bjorn Andersson <bjorn.andersson@....qualcomm.com>,
	Wesley Cheng <quic_wcheng@...cinc.com>,
	Jack Pham <quic_jackp@...cinc.com>,
	Raghavendra Thoorpu <rthoorpu@....qualcomm.com>,
	Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>,
	Mayank Rana <mayank.rana@....qualcomm.com>,
	Krishna Kurapati <krishna.kurapati@....qualcomm.com>,
	Manivannan Sadhasivam <manivannan.sadhasivam@....qualcomm.com>,
	linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Andreas Noever <andreas.noever@...il.com>,
	Mika Westerberg <westeri@...nel.org>,
	Yehezkel Bernat <YehezkelShB@...il.com>, linux-usb@...r.kernel.org
Subject: Re: [PATCH RFC] dt-bindings: thunderbolt: Add Qualcomm USB4 Host
 Router

Hi,

On Thu, Sep 18, 2025 at 11:05:42AM +0200, Konrad Dybcio wrote:
> > I it hard to change these DT bindings later on? If yes then I would
> > definitely think forward and make this support MSI from the get-go.
> 
> dt-bindings (attempt to) promise an ABI-like interface, so bindings
> for *a given IP block* ("dt-bindings describe the hardware") should
> not change, unless there's something critically wrong (e.g. "this
> could have never really worked").

Then I think it is good to think few steps forward and make sure when
Qualcomm adds MSI to their IP it can be easily desribed in the DT bindings.

> Adding new properties is always OK, marking the new properties  as
> 'required' is not (unless it falls into the aforementioned case).
> 
> It's also totally OK to add MSI properties to e.g. Apple Host Router
> bindings specifically when they come around, as it's simply a different
> piece of hardware. It's also OK to create a usb4-host-router.yaml down
> the line, which will act as a common include and perform any
> maintenance/code churn, so long as it doesn't end up in the bindings
> for any specific hw block (e.g. this QC one) becoming more strict
> than they were on HEAD^.

Okay thanks for the explanation.