linux-kernel - Re: [PATCH v3 1/3] arm64: dts: rockchip: disable display subsystem for Radxa E52C

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <10594621.0AQdONaE2F@diego>
Date: Thu, 18 Sep 2025 19:31:05 +0200
From: Heiko Stübner <heiko@...ech.de>
To: Chukun Pan <amadeus@....edu.cn>
Cc: Chukun Pan <amadeus@....edu.cn>, FUKAUMI Naoki <naoki@...xa.com>,
 Conor Dooley <conor+dt@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Rob Herring <robh@...nel.org>, linux-arm-kernel@...ts.infradead.org,
 linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
 devicetree@...r.kernel.org
Subject:
 Re: [PATCH v3 1/3] arm64: dts: rockchip: disable display subsystem for Radxa
 E52C

Am Montag, 1. September 2025, 12:00:25 Mitteleuropäische Sommerzeit schrieb Chukun Pan:
> The Radxa E52C SBC do not have HDMI output, so disable
> the display subsystem to avoid the following error log:
> 
> *ERROR* No available vop found for display-subsystem.
> 
> Fixes: 9be4171219b6 ("arm64: dts: rockchip: Add Radxa E52C")
> Signed-off-by: Chukun Pan <amadeus@....edu.cn>

I'm torn on the approach vs. just removing the error line in the driver.

Returning -ENODEV from rockchip_drm_platform_of_probe() is correct,
but the error log could just be a debug one instead.

Because running a system without active vops is obviously fine.


Heiko

> ---
>  arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts b/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
> index 48ddc43e2ab5..1883bd183396 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
> @@ -207,6 +207,10 @@ &cpu_l3 {
>  	cpu-supply = <&vdd_cpu_lit_s0>;
>  };
>  
> +&display_subsystem {
> +	status = "disabled";
> +};
> +
>  &i2c0 {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&i2c0m2_xfer>;
>