linux-kernel - Re: [PATCH net v4 0/3] net: phy: smsc: use IRQ + relaxed polling to fix missed link-up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a873e8e3-e1c9-4e82-b3e8-4b1cc8052a73@lunn.ch>
Date: Thu, 18 Sep 2025 21:48:33 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Oleksij Rempel <o.rempel@...gutronix.de>
Cc: Heiner Kallweit <hkallweit1@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	kernel@...gutronix.de, linux-kernel@...r.kernel.org,
	Russell King <linux@...linux.org.uk>, netdev@...r.kernel.org,
	Andre Edich <andre.edich@...rochip.com>,
	Lukas Wunner <lukas@...ner.de>
Subject: Re: [PATCH net v4 0/3] net: phy: smsc: use IRQ + relaxed polling to
 fix missed link-up

> How about a minimal change instead: conditionally call
> phy_queue_state_machine() from lan87xx_config_aneg()? That would trigger
> a poll in the broken mode without touching phydev->irq or core teardown
> paths. Seems less intrusive than rewriting IRQ handling.

It is currently a static function, so that would have to change.

Or it might be better to add phy_trigger_machine_soon(), using the
default 1 second delay? And i would document it as only to be used by
broken PHYs, to try to stop it being abused. Anybody using it needs to
acknowledge their PHY is broken.

	Andrew