linux-kernel - Re: [PATCH v3 05/35] checkpatch: Warn about capability

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <13389786a2a121c21a6f4940b4acf09fad53a3d9.camel@perches.com>
Date: Thu, 18 Sep 2025 13:36:43 -0700
From: Joe Perches <joe@...ches.com>
To: Marco Elver <elver@...gle.com>, Peter Zijlstra <peterz@...radead.org>, 
 Boqun Feng <boqun.feng@...il.com>, Ingo Molnar <mingo@...nel.org>, Will
 Deacon <will@...nel.org>
Cc: "David S. Miller" <davem@...emloft.net>, Luc Van Oostenryck	
 <luc.vanoostenryck@...il.com>, "Paul E. McKenney" <paulmck@...nel.org>, 
 Alexander Potapenko	 <glider@...gle.com>, Arnd Bergmann <arnd@...db.de>,
 Bart Van Assche	 <bvanassche@....org>, Bill Wendling <morbo@...gle.com>,
 Christoph Hellwig	 <hch@....de>, Dmitry Vyukov <dvyukov@...gle.com>, Eric
 Dumazet	 <edumazet@...gle.com>, Frederic Weisbecker <frederic@...nel.org>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Herbert Xu
 <herbert@...dor.apana.org.au>, Ian Rogers	 <irogers@...gle.com>, Jann Horn
 <jannh@...gle.com>, Joel Fernandes	 <joelagnelf@...dia.com>, Jonathan
 Corbet <corbet@....net>, Josh Triplett	 <josh@...htriplett.org>, Justin
 Stitt <justinstitt@...gle.com>, Kees Cook	 <kees@...nel.org>, Kentaro
 Takeda <takedakn@...data.co.jp>, Lukas Bulwahn	 <lukas.bulwahn@...il.com>,
 Mark Rutland <mark.rutland@....com>, Mathieu Desnoyers
 <mathieu.desnoyers@...icios.com>, Miguel Ojeda <ojeda@...nel.org>, Nathan
 Chancellor	 <nathan@...nel.org>, Neeraj Upadhyay
 <neeraj.upadhyay@...nel.org>, Nick Desaulniers
 <nick.desaulniers+lkml@...il.com>, Steven Rostedt <rostedt@...dmis.org>,
 Tetsuo Handa	 <penguin-kernel@...ove.SAKURA.ne.jp>, Thomas Gleixner
 <tglx@...utronix.de>,  Thomas Graf <tgraf@...g.ch>, Uladzislau Rezki
 <urezki@...il.com>, Waiman Long <longman@...hat.com>, 
	kasan-dev@...glegroups.com, linux-crypto@...r.kernel.org, 
	linux-doc@...r.kernel.org, linux-kbuild@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-mm@...ck.org, 
	linux-security-module@...r.kernel.org, linux-sparse@...r.kernel.org, 
	llvm@...ts.linux.dev, rcu@...r.kernel.org
Subject: Re: [PATCH v3 05/35] checkpatch: Warn about capability_unsafe()
 without comment

On Thu, 2025-09-18 at 15:59 +0200, Marco Elver wrote:
> Warn about applications of capability_unsafe() without a comment, to
> encourage documenting the reasoning behind why it was deemed safe.
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -6717,6 +6717,14 @@ sub process {
>  			}
>  		}
>  
> +# check for capability_unsafe without a comment.
> +		if ($line =~ /\bcapability_unsafe\b/) {
> +			if (!ctx_has_comment($first_line, $linenr)) {
> +				WARN("CAPABILITY_UNSAFE",
> +				     "capability_unsafe without comment\n" . $herecurr);

while most of these are using the same multi-line style
I'd prefer combining and reducing indentation

		if ($line =~ /\bcapability_unsafe\b/ &&
		    !ctx_has_comment($first_line, $linenr)) {
			WARN(etc...