linux-kernel - Re: [PATCH] coresight: Fix data argument to coresight_enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87frcj8kw7.fsf@rasp.cworth.amperemail.amperecomputing.com>
Date: Thu, 18 Sep 2025 17:18:32 -0500
From: Carl Worth <carl@...amperecomputing.com>
To: Jie Gan <jie.gan@....qualcomm.com>, Suzuki K Poulose
 <suzuki.poulose@....com>, Mike Leach <mike.leach@...aro.org>, James Clark
 <james.clark@...aro.org>, Alexander Shishkin
 <alexander.shishkin@...ux.intel.com>, Sabrina Dubroca <sd@...asysnail.net>
Cc: coresight@...ts.linaro.org, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] coresight: Fix data argument to coresight_enable_helpers

Jie Gan <jie.gan@....qualcomm.com> writes:
> I dont think we can change back to sink_data since we introduced 
> coresight_path to wrap 'data' which is needed by the path.
>
> I suggest you to add the struct perf_output_handle to the 
> coresight_path, then retrieving it with data->perf_handle in 
> tmc_etr_get_buffer.
...
> We can assign the perf_output_handle to the coresight_path after we 
> constructed the coresight_path in perf mode.

Thanks. That much makes sense to me, and I'll put together a patch along
those lines.

But, further: with core coresight code assembling into the path all the
data that is necessary, is there any reason to be using void* in these
enable/disable functions?

Could we also change these functions to accept a coresight_path* and
actually get some compiler help at finding mistakes like the one we're
fixing here?

-Carl