linux-kernel - [PATCH] drivers/base/node: Fix double free in register_one

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250918054144.58980-1-donettom@linux.ibm.com>
Date: Thu, 18 Sep 2025 11:11:44 +0530
From: Donet Tom <donettom@...ux.ibm.com>
To: akpm@...ux-foundation.org, clm@...a.com
Cc: Jonathan.Cameron@...wei.com, alison.schofield@...el.com, dakr@...nel.org,
        dave.jiang@...el.com, david@...hat.com, gregkh@...uxfoundation.org,
        kamezawa.hiroyu@...fujitsu.com, linux-kernel@...r.kernel.org,
        linux-mm@...ck.org, osalvador@...e.de, rafael@...nel.org,
        ritesh.list@...il.com, yury.norov@...il.com, ziy@...dia.com,
        Donet Tom <donettom@...ux.ibm.com>
Subject: [PATCH] drivers/base/node: Fix double free in register_one_node()

When device_register() fails in register_node(), it calls
put_device(&node->dev). This triggers node_device_release(),
which calls kfree(to_node(dev)), thereby freeing the entire
node structure.

As a result, when register_node() returns an error, the node
memory has already been freed. Calling kfree(node) again in
register_one_node() leads to a double free.

This patch removes the redundant kfree(node) from
register_one_node() to prevent the double free.

Fixes: 786eb990cfb7 ("drivers/base/node: handle error properly in register_one_node()")
Signed-off-by: Donet Tom <donettom@...ux.ibm.com>
---
 drivers/base/node.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/base/node.c b/drivers/base/node.c
index 1608816de67f..6b6e55a98b79 100644
--- a/drivers/base/node.c
+++ b/drivers/base/node.c
@@ -885,7 +885,6 @@ int register_one_node(int nid)
 	error = register_node(node_devices[nid], nid);
 	if (error) {
 		node_devices[nid] = NULL;
-		kfree(node);
 		return error;
 	}
 
-- 
2.51.0