linux-kernel - Re: [PATCH v3 2/7] dt-bindings: media: fsd: Add CSIS video capture interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4b12915d-b12d-402e-b4d0-5c2bc7b7ca35@kernel.org>
Date: Thu, 18 Sep 2025 09:01:55 +0900
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Inbaraj E <inbaraj.e@...sung.com>
Cc: rmfrfs@...il.com, laurent.pinchart@...asonboard.com, martink@...teo.de,
 kernel@...i.sm, mchehab@...nel.org, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, shawnguo@...nel.org, s.hauer@...gutronix.de,
 kernel@...gutronix.de, festevam@...il.com, linux-media@...r.kernel.org,
 devicetree@...r.kernel.org, imx@...ts.linux.dev,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 linux-samsung-soc@...r.kernel.org, pankaj.dubey@...sung.com,
 ravi.patel@...sung.com, shradha.t@...sung.com
Subject: Re: [PATCH v3 2/7] dt-bindings: media: fsd: Add CSIS video capture
 interface

On 17/09/2025 21:13, Inbaraj E wrote:
>>> +examples:
>>> +  - |
>>> +    #include <dt-bindings/clock/fsd-clk.h>
>>> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
>>> +
>>> +    csis0: csis@...41000 {
>>
>> Incorrect unit address.
> 
> Thanks for pointing out.
> Unit address is correct. Address in reg is wrong here I'll fix in next patchset.

That's even worse, because it means the corresponding DTS was never tested.

Best regards,
Krzysztof