| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202509181359.fLTuROj6-lkp@intel.com>
Date: Thu, 18 Sep 2025 13:49:02 +0800
From: kernel test robot <lkp@...el.com>
To: Slawomir Rosek <srosek@...gle.com>,
"Rafael J . Wysocki" <rafael@...nel.org>,
Alex Hung <alexhung@...il.com>, Hans de Goede <hansg@...nel.org>,
Ilpo Jarvinen <ilpo.jarvinen@...ux.intel.com>,
AceLan Kao <acelan.kao@...onical.com>,
Daniel Lezcano <daniel.lezcano@...aro.org>
Cc: oe-kbuild-all@...ts.linux.dev,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Zhang Rui <rui.zhang@...el.com>,
Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
Tomasz Nowicki <tnowicki@...gle.com>,
Stanislaw Kardach <skardach@...gle.com>,
Michal Krawczyk <mikrawczyk@...gle.com>,
linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org,
platform-driver-x86@...r.kernel.org, linux-pm@...r.kernel.org,
Slawomir Rosek <srosek@...gle.com>
Subject: Re: [PATCH v2 1/6] ACPI: DPTF: Ignore SoC DTS thermal while scanning
Hi Slawomir,
kernel test robot noticed the following build errors:
[auto build test ERROR on rafael-pm/linux-next]
[also build test ERROR on rafael-pm/bleeding-edge rafael-pm/thermal driver-core/driver-core-testing driver-core/driver-core-next driver-core/driver-core-linus linus/master v6.17-rc6 next-20250917]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Slawomir-Rosek/ACPI-DPTF-Ignore-SoC-DTS-thermal-while-scanning/20250917-201033
base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
patch link: https://lore.kernel.org/r/20250917120719.2390847-2-srosek%40google.com
patch subject: [PATCH v2 1/6] ACPI: DPTF: Ignore SoC DTS thermal while scanning
config: i386-randconfig-003-20250918 (https://download.01.org/0day-ci/archive/20250918/202509181359.fLTuROj6-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250918/202509181359.fLTuROj6-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202509181359.fLTuROj6-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/thermal/intel/int340x_thermal/platform_temperature_control.c: In function 'ptc_mmio_show':
>> drivers/thermal/intel/int340x_thermal/platform_temperature_control.c:110:19: error: implicit declaration of function 'readq'; did you mean 'readl'? [-Wimplicit-function-declaration]
110 | reg_val = readq((void __iomem *) (proc_priv->mmio_base + data->offset));
| ^~~~~
| readl
drivers/thermal/intel/int340x_thermal/platform_temperature_control.c: In function 'ptc_mmio_write':
>> drivers/thermal/intel/int340x_thermal/platform_temperature_control.c:142:9: error: implicit declaration of function 'writeq'; did you mean 'writel'? [-Wimplicit-function-declaration]
142 | writeq(reg_val, (void __iomem *) (proc_priv->mmio_base + offset));
| ^~~~~~
| writel
--
drivers/thermal/intel/int340x_thermal/int340x_thermal_zone.c: In function 'int340x_thermal_read_trips':
>> drivers/thermal/intel/int340x_thermal/int340x_thermal_zone.c:72:15: error: implicit declaration of function 'thermal_acpi_critical_trip_temp'; did you mean 'thermal_zone_set_trip_temp'? [-Wimplicit-function-declaration]
72 | ret = thermal_acpi_critical_trip_temp(zone_adev,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| thermal_zone_set_trip_temp
>> drivers/thermal/intel/int340x_thermal/int340x_thermal_zone.c:79:15: error: implicit declaration of function 'thermal_acpi_hot_trip_temp'; did you mean 'thermal_zone_set_trip_temp'? [-Wimplicit-function-declaration]
79 | ret = thermal_acpi_hot_trip_temp(zone_adev,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
| thermal_zone_set_trip_temp
>> drivers/thermal/intel/int340x_thermal/int340x_thermal_zone.c:86:15: error: implicit declaration of function 'thermal_acpi_passive_trip_temp'; did you mean 'thermal_zone_set_trip_temp'? [-Wimplicit-function-declaration]
86 | ret = thermal_acpi_passive_trip_temp(zone_adev,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| thermal_zone_set_trip_temp
>> drivers/thermal/intel/int340x_thermal/int340x_thermal_zone.c:94:23: error: implicit declaration of function 'thermal_acpi_active_trip_temp'; did you mean 'thermal_zone_set_trip_temp'? [-Wimplicit-function-declaration]
94 | ret = thermal_acpi_active_trip_temp(zone_adev, i,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| thermal_zone_set_trip_temp
--
drivers/thermal/intel/int340x_thermal/processor_thermal_power_floor.c: In function 'proc_thermal_read_power_floor_status':
>> drivers/thermal/intel/int340x_thermal/processor_thermal_power_floor.c:42:18: error: implicit declaration of function 'readq'; did you mean 'readl'? [-Wimplicit-function-declaration]
42 | status = readq(proc_priv->mmio_base + SOC_WT_RES_INT_STATUS_OFFSET);
| ^~~~~
| readl
In file included from include/linux/bits.h:5,
from include/linux/ratelimit_types.h:5,
from include/linux/printk.h:9,
from include/asm-generic/bug.h:22,
from arch/x86/include/asm/bug.h:103,
from include/linux/bug.h:5,
from include/linux/fortify-string.h:6,
from include/linux/string.h:382,
from include/linux/uuid.h:11,
from include/linux/mod_devicetable.h:14,
from include/linux/pci.h:27,
from drivers/thermal/intel/int340x_thermal/processor_thermal_power_floor.c:29:
include/vdso/bits.h:7:40: warning: left shift count >= width of type [-Wshift-count-overflow]
7 | #define BIT(nr) (UL(1) << (nr))
| ^~
drivers/thermal/intel/int340x_thermal/processor_thermal_power_floor.c:32:41: note: in expansion of macro 'BIT'
32 | #define SOC_POWER_FLOOR_STATUS BIT(39)
| ^~~
drivers/thermal/intel/int340x_thermal/processor_thermal_power_floor.c:43:26: note: in expansion of macro 'SOC_POWER_FLOOR_STATUS'
43 | return (status & SOC_POWER_FLOOR_STATUS) >> SOC_POWER_FLOOR_SHIFT;
| ^~~~~~~~~~~~~~~~~~~~~~
--
drivers/thermal/intel/int340x_thermal/processor_thermal_wt_hint.c: In function 'workload_type_index_show':
>> drivers/thermal/intel/int340x_thermal/processor_thermal_wt_hint.c:69:18: error: implicit declaration of function 'readq'; did you mean 'readl'? [-Wimplicit-function-declaration]
69 | status = readq(proc_priv->mmio_base + SOC_WT_RES_INT_STATUS_OFFSET);
| ^~~~~
| readl
--
drivers/thermal/intel/int340x_thermal/processor_thermal_device_pci.c: In function 'proc_thermal_clear_soc_int_status':
>> drivers/thermal/intel/int340x_thermal/processor_thermal_device_pci.c:145:18: error: implicit declaration of function 'readq'; did you mean 'readl'? [-Wimplicit-function-declaration]
145 | status = readq(proc_priv->mmio_base + SOC_WT_RES_INT_STATUS_OFFSET);
| ^~~~~
| readl
>> drivers/thermal/intel/int340x_thermal/processor_thermal_device_pci.c:146:9: error: implicit declaration of function 'writeq'; did you mean 'writel'? [-Wimplicit-function-declaration]
146 | writeq(status & ~SOC_WT_RES_INT_STATUS_MASK,
| ^~~~~~
| writel
--
drivers/thermal/intel/int340x_thermal/processor_thermal_soc_slider.c: In function 'read_soc_slider':
>> drivers/thermal/intel/int340x_thermal/processor_thermal_soc_slider.c:166:16: error: implicit declaration of function 'readq'; did you mean 'readl'? [-Wimplicit-function-declaration]
166 | return readq(proc_priv->mmio_base + SOC_POWER_SLIDER_OFFSET);
| ^~~~~
| readl
drivers/thermal/intel/int340x_thermal/processor_thermal_soc_slider.c: In function 'write_soc_slider':
>> drivers/thermal/intel/int340x_thermal/processor_thermal_soc_slider.c:171:9: error: implicit declaration of function 'writeq'; did you mean 'writel'? [-Wimplicit-function-declaration]
171 | writeq(val, proc_priv->mmio_base + SOC_POWER_SLIDER_OFFSET);
| ^~~~~~
| writel
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for INT340X_THERMAL
Depends on [n]: THERMAL [=y] && (X86 [=y] || X86_INTEL_QUARK [=n] || COMPILE_TEST [=n]) && X86_64 [=n] && ACPI [=y] && PCI [=y] && NET [=y]
Selected by [y]:
- INTEL_SOC_DTS_THERMAL [=y] && THERMAL [=y] && (X86 [=y] || X86_INTEL_QUARK [=n] || COMPILE_TEST [=n]) && X86 [=y] && PCI [=y] && ACPI [=y]
vim +110 drivers/thermal/intel/int340x_thermal/platform_temperature_control.c
9befea30133ca4 Srinivas Pandruvada 2025-04-28 90
9befea30133ca4 Srinivas Pandruvada 2025-04-28 91 static ssize_t ptc_mmio_show(struct ptc_data *data, struct device *dev,
9befea30133ca4 Srinivas Pandruvada 2025-04-28 92 struct device_attribute *attr, char *buf)
9befea30133ca4 Srinivas Pandruvada 2025-04-28 93 {
9befea30133ca4 Srinivas Pandruvada 2025-04-28 94 struct pci_dev *pdev = to_pci_dev(dev);
9befea30133ca4 Srinivas Pandruvada 2025-04-28 95 struct proc_thermal_device *proc_priv;
9befea30133ca4 Srinivas Pandruvada 2025-04-28 96 const struct mmio_reg *mmio_regs;
9befea30133ca4 Srinivas Pandruvada 2025-04-28 97 int ret, units;
9befea30133ca4 Srinivas Pandruvada 2025-04-28 98 u64 reg_val;
9befea30133ca4 Srinivas Pandruvada 2025-04-28 99
9befea30133ca4 Srinivas Pandruvada 2025-04-28 100 proc_priv = pci_get_drvdata(pdev);
9befea30133ca4 Srinivas Pandruvada 2025-04-28 101 mmio_regs = ptc_mmio_regs;
9befea30133ca4 Srinivas Pandruvada 2025-04-28 102 ret = match_string(ptc_strings, -1, attr->attr.name);
9befea30133ca4 Srinivas Pandruvada 2025-04-28 103 if (ret < 0)
9befea30133ca4 Srinivas Pandruvada 2025-04-28 104 return ret;
9befea30133ca4 Srinivas Pandruvada 2025-04-28 105
9befea30133ca4 Srinivas Pandruvada 2025-04-28 106 units = mmio_regs[ret].units;
9befea30133ca4 Srinivas Pandruvada 2025-04-28 107
9befea30133ca4 Srinivas Pandruvada 2025-04-28 108 guard(mutex)(&ptc_lock);
9befea30133ca4 Srinivas Pandruvada 2025-04-28 109
9befea30133ca4 Srinivas Pandruvada 2025-04-28 @110 reg_val = readq((void __iomem *) (proc_priv->mmio_base + data->offset));
9befea30133ca4 Srinivas Pandruvada 2025-04-28 111 ret = (reg_val >> mmio_regs[ret].shift) & mmio_regs[ret].mask;
9befea30133ca4 Srinivas Pandruvada 2025-04-28 112 if (units)
9befea30133ca4 Srinivas Pandruvada 2025-04-28 113 ret *= units;
9befea30133ca4 Srinivas Pandruvada 2025-04-28 114
9befea30133ca4 Srinivas Pandruvada 2025-04-28 115 return sysfs_emit(buf, "%d\n", ret);
9befea30133ca4 Srinivas Pandruvada 2025-04-28 116 }
9befea30133ca4 Srinivas Pandruvada 2025-04-28 117
9befea30133ca4 Srinivas Pandruvada 2025-04-28 118 #define PTC_SHOW(suffix)\
9befea30133ca4 Srinivas Pandruvada 2025-04-28 119 static ssize_t suffix##_show(struct device *dev,\
9befea30133ca4 Srinivas Pandruvada 2025-04-28 120 struct device_attribute *attr,\
9befea30133ca4 Srinivas Pandruvada 2025-04-28 121 char *buf)\
9befea30133ca4 Srinivas Pandruvada 2025-04-28 122 {\
9befea30133ca4 Srinivas Pandruvada 2025-04-28 123 struct ptc_data *data = container_of(attr, struct ptc_data, suffix##_attr);\
9befea30133ca4 Srinivas Pandruvada 2025-04-28 124 return ptc_mmio_show(data, dev, attr, buf);\
9befea30133ca4 Srinivas Pandruvada 2025-04-28 125 }
9befea30133ca4 Srinivas Pandruvada 2025-04-28 126
9befea30133ca4 Srinivas Pandruvada 2025-04-28 127 static void ptc_mmio_write(struct pci_dev *pdev, u32 offset, int index, u32 value)
9befea30133ca4 Srinivas Pandruvada 2025-04-28 128 {
9befea30133ca4 Srinivas Pandruvada 2025-04-28 129 struct proc_thermal_device *proc_priv;
9befea30133ca4 Srinivas Pandruvada 2025-04-28 130 u64 mask, reg_val;
9befea30133ca4 Srinivas Pandruvada 2025-04-28 131
9befea30133ca4 Srinivas Pandruvada 2025-04-28 132 proc_priv = pci_get_drvdata(pdev);
9befea30133ca4 Srinivas Pandruvada 2025-04-28 133
9befea30133ca4 Srinivas Pandruvada 2025-04-28 134 mask = GENMASK_ULL(ptc_mmio_regs[index].shift + ptc_mmio_regs[index].bits - 1,
9befea30133ca4 Srinivas Pandruvada 2025-04-28 135 ptc_mmio_regs[index].shift);
9befea30133ca4 Srinivas Pandruvada 2025-04-28 136
9befea30133ca4 Srinivas Pandruvada 2025-04-28 137 guard(mutex)(&ptc_lock);
9befea30133ca4 Srinivas Pandruvada 2025-04-28 138
9befea30133ca4 Srinivas Pandruvada 2025-04-28 139 reg_val = readq((void __iomem *) (proc_priv->mmio_base + offset));
9befea30133ca4 Srinivas Pandruvada 2025-04-28 140 reg_val &= ~mask;
9befea30133ca4 Srinivas Pandruvada 2025-04-28 141 reg_val |= (value << ptc_mmio_regs[index].shift);
9befea30133ca4 Srinivas Pandruvada 2025-04-28 @142 writeq(reg_val, (void __iomem *) (proc_priv->mmio_base + offset));
9befea30133ca4 Srinivas Pandruvada 2025-04-28 143 }
9befea30133ca4 Srinivas Pandruvada 2025-04-28 144
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists