linux-kernel - Re: [PATCH] drm/bridge: waveshare-dsi: Fix bailout for devm_drm_bridge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cb6dd5ca-f5ae-4acb-8154-d9725ea80ce4@nxp.com>
Date: Thu, 18 Sep 2025 14:02:34 +0800
From: Liu Ying <victor.liu@....com>
To: dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Cc: andrzej.hajda@...el.com, neil.armstrong@...aro.org, rfoss@...nel.org,
 Laurent.pinchart@...asonboard.com, jonas@...boo.se,
 jernej.skrabec@...il.com, maarten.lankhorst@...ux.intel.com,
 mripard@...nel.org, tzimmermann@...e.de, airlied@...il.com, simona@...ll.ch,
 qijian.guo@....com
Subject: Re: [PATCH] drm/bridge: waveshare-dsi: Fix bailout for
 devm_drm_bridge_alloc()

On 09/05/2025, Liu Ying wrote:
> On 8/6/25 16:41, Liu Ying wrote:
>> devm_drm_bridge_alloc() returns ERR_PTR on failure instead of a
>> NULL pointer, so use IS_ERR() to check the returned pointer and
>> turn proper error code on failure by using PTR_ERR().
>>
>> Fixes: dbdea37add13 ("drm: bridge: Add waveshare DSI2DPI unit driver")
>> Signed-off-by: Liu Ying <victor.liu@....com>
>> ---
>>  drivers/gpu/drm/bridge/waveshare-dsi.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> Gentle ping for review.

Ping again.

> 
>>
>> diff --git a/drivers/gpu/drm/bridge/waveshare-dsi.c b/drivers/gpu/drm/bridge/waveshare-dsi.c
>> index 01c70e7d3d3b..43f4e7412d72 100644
>> --- a/drivers/gpu/drm/bridge/waveshare-dsi.c
>> +++ b/drivers/gpu/drm/bridge/waveshare-dsi.c
>> @@ -147,8 +147,8 @@ static int ws_bridge_probe(struct i2c_client *i2c)
>>  	int ret;
>>  
>>  	ws = devm_drm_bridge_alloc(dev, struct ws_bridge, bridge, &ws_bridge_bridge_funcs);
>> -	if (!ws)
>> -		return -ENOMEM;
>> +	if (IS_ERR(ws))
>> +		return PTR_ERR(ws);
>>  
>>  	ws->dev = dev;
>>  
> 


-- 
Regards,
Liu Ying