linux-kernel - Re: [PATCH v1] tty: serial: qcom_geni_serial: Fix error handling for RS485 mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAP0YdSqCD8MZPrj0ekDHG4LhoGm4s3qs_z0xubD5hQ=vBOv9_g@mail.gmail.com>
Date: Thu, 18 Sep 2025 12:04:42 +0530
From: Anup Kulkarni <anup.kulkarni@....qualcomm.com>
To: Greg KH <gregkh@...uxfoundation.org>
Cc: jirislaby@...nel.org, johan+linaro@...nel.org, dianders@...omium.org,
        quic_ptalari@...cinc.com, bryan.odonoghue@...aro.org,
        quic_zongjian@...cinc.com, quic_jseerapu@...cinc.com,
        quic_vdadhani@...cinc.com, linux-arm-msm@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
        mukesh.savaliya@....qualcomm.com, viken.dadhaniya@....qualcomm.com,
        stable@...r.kernel.org
Subject: Re: [PATCH v1] tty: serial: qcom_geni_serial: Fix error handling for
 RS485 mode

On Wed, Sep 17, 2025 at 4:45 PM Greg KH <gregkh@...uxfoundation.org> wrote:
>
> On Tue, Sep 16, 2025 at 03:09:57PM +0530, Anup Kulkarni wrote:
> > If uart_get_rs485() fails, the driver returns without detaching
> > the PM domain list.
> >
> > Fix the error handling path in uart_get_rs485_mode() to ensure the
> > PM domain list is detached before exiting.
> >
> > Fixes: 86fa39dd6fb7 ("serial: qcom-geni: Enable Serial on SA8255p Qualcomm platforms")
> > Cc: stable@...r.kernel.org
> > Signed-off-by: Anup Kulkarni <anup.kulkarni@....qualcomm.com>
> > ---
> >  drivers/tty/serial/qcom_geni_serial.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
>
> I've taken
> https://lore.kernel.org/r/20250917010437.129912-2-krzysztof.kozlowski@linaro.org
> instead, so this shouldn't be needed anymore.
>
Agree. It's not required now.
> thanks,
>
> greg k-h

thanks,

Anup