linux-kernel - [PATCH] can: rcar_canfd: Fix controller mode setting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <TYWPR01MB87434739F83E27EDCD23DF44B416A@TYWPR01MB8743.jpnprd01.prod.outlook.com>
Date: Thu, 18 Sep 2025 07:03:45 +0000
From: Duy Nguyen <duy.nguyen.rh@...esas.com>
To: "mkl@...gutronix.de" <mkl@...gutronix.de>, "mailhol.vincent@...adoo.fr"
	<mailhol.vincent@...adoo.fr>, Geert Uytterhoeven <geert+renesas@...der.be>,
	magnus.damm <magnus.damm@...il.com>, Biju Das <biju.das.jz@...renesas.com>,
	"socketcan@...tkopp.net" <socketcan@...tkopp.net>, Duy Nguyen
	<duy.nguyen.rh@...esas.com>, "linux-can@...r.kernel.org"
	<linux-can@...r.kernel.org>, "linux-renesas-soc@...r.kernel.org"
	<linux-renesas-soc@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
CC: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>, Nguyen Hong Thuan
	<thuan.nguyen-hong@...vien.com.vn>, Tong Duc Duy
	<duy.tong-duc@...vien.com.vn>, Tranh Ha <tranh.ha.xb@...esas.com>, Minh Le
	<minh.le.aj@...esas.com>
Subject: [PATCH] can: rcar_canfd: Fix controller mode setting

Driver configures register to choose controller mode before
setting all channels to reset mode leading to failure.
The patch corrects operation of mode setting.

Signed-off-by: Duy Nguyen <duy.nguyen.rh@...esas.com>
Signed-off-by: Tranh Ha <tranh.ha.xb@...esas.com>
---
 drivers/net/can/rcar/rcar_canfd.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/net/can/rcar/rcar_canfd.c b/drivers/net/can/rcar/rcar_canfd.c
index 7f10213738e5..e2ae8d6a9de6 100644
--- a/drivers/net/can/rcar/rcar_canfd.c
+++ b/drivers/net/can/rcar/rcar_canfd.c
@@ -870,9 +870,6 @@ static int rcar_canfd_reset_controller(struct rcar_canfd_global *gpriv)
 	/* Reset Global error flags */
 	rcar_canfd_write(gpriv->base, RCANFD_GERFL, 0x0);
 
-	/* Set the controller into appropriate mode */
-	rcar_canfd_set_mode(gpriv);
-
 	/* Transition all Channels to reset mode */
 	for_each_set_bit(ch, &gpriv->channels_mask, gpriv->info->max_channels) {
 		rcar_canfd_clear_bit(gpriv->base,
@@ -892,6 +889,10 @@ static int rcar_canfd_reset_controller(struct rcar_canfd_global *gpriv)
 			return err;
 		}
 	}
+
+	/* Set the controller into appropriate mode */
+	rcar_canfd_set_mode(gpriv);
+
 	return 0;
 }
 
-- 
2.25.1