linux-kernel - Re: [PATCH v2] mm/memory-failure: Support disabling soft offline for HugeTLB pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1211fd9a-93e6-4ebe-a80d-083601138b70@linux.alibaba.com>
Date: Thu, 18 Sep 2025 16:34:03 +0800
From: Shuai Xue <xueshuai@...ux.alibaba.com>
To: Kyle Meyer <kyle.meyer@....com>, "Fan, Shawn" <shawn.fan@...el.com>
Cc: "Luck, Tony" <tony.luck@...el.com>,
 Andrew Morton <akpm@...ux-foundation.org>, "corbet@....net"
 <corbet@....net>, "david@...hat.com" <david@...hat.com>,
 "linmiaohe@...wei.com" <linmiaohe@...wei.com>,
 "shuah@...nel.org" <shuah@...nel.org>,
 "jane.chu@...cle.com" <jane.chu@...cle.com>,
 "jiaqiyan@...gle.com" <jiaqiyan@...gle.com>,
 "Liam.Howlett@...cle.com" <Liam.Howlett@...cle.com>,
 "bp@...en8.de" <bp@...en8.de>, "hannes@...xchg.org" <hannes@...xchg.org>,
 "jack@...e.cz" <jack@...e.cz>,
 "joel.granados@...nel.org" <joel.granados@...nel.org>,
 "laoar.shao@...il.com" <laoar.shao@...il.com>,
 "lorenzo.stoakes@...cle.com" <lorenzo.stoakes@...cle.com>,
 "mclapinski@...gle.com" <mclapinski@...gle.com>,
 "mhocko@...e.com" <mhocko@...e.com>,
 "nao.horiguchi@...il.com" <nao.horiguchi@...il.com>,
 "osalvador@...e.de" <osalvador@...e.de>,
 "Wysocki, Rafael J" <rafael.j.wysocki@...el.com>,
 "rppt@...nel.org" <rppt@...nel.org>, "Anderson, Russ"
 <russ.anderson@....com>, "surenb@...gle.com" <surenb@...gle.com>,
 "vbabka@...e.cz" <vbabka@...e.cz>,
 "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
 "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>,
 "linux-mm@...ck.org" <linux-mm@...ck.org>
Subject: Re: [PATCH v2] mm/memory-failure: Support disabling soft offline for
 HugeTLB pages



在 2025/9/18 02:59, Kyle Meyer 写道:
> On Wed, Sep 17, 2025 at 06:35:14AM +0000, Fan, Shawn wrote:
>>>> My original patch for this just skipped the GHES->offline process
>>>> for huge pages. But I wasn't aware of the sysctl control. That provides
>>>> a better solution.
>>>
>>> Tony, does that mean you're OK with using the existing sysctl interface? If
>>> so, I'll just send a separate patch to update the sysfs-memory-page-offline
>>> documentation and drop the rest.
>>
>> Kyle,
>>
>> It depends on which camp the external customer that reported this
>> falls into:
>>
>> 1) "I'm OK disabling all soft offline requests".
>>
>> or the:
>>
>> 2) "I'd like 4K pages to still go offline if the BIOS asks, just not any huge pages".
>>
>> Shawn: Can you please find out?
>>
>>
>> -> Prefer the 2nd option,  "4K pages still go offline if the BIOS asks, just not any huge pages."
> 
> OK, thank you.
> 
> Does that mean they want to avoid offlining transparent huge pages as well?
> 
> Thanks,
> Kyle Meyer


Hi, Shawn,

As memory access is typically interleaved between channels. When the
per-rank threshold is exceeded, soft-offlining the last accessed address
seems unreasonable - regardless of whether it's a 4KB page or a huge
page. The error accumulation happens at the rank level, but the action
is taken on a specific page that happened to trigger the threshold,
which doesn't address the underlying issue.

I prefer the first option that disabling all soft offline requests from
GHES driver.

Thanks.
Shuai