linux-kernel - Re: [PATCH 3/4] regulator: Support the LTM8054 voltage regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <12775482.O9o76ZdvQC@fw-rgant>
Date: Thu, 18 Sep 2025 11:31:50 +0200
From: Romain Gantois <romain.gantois@...tlin.com>
To: Andy Shevchenko <andriy.shevchenko@...el.com>
Cc: Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Jonathan Cameron <jic23@...nel.org>,
 David Lechner <dlechner@...libre.com>,
 Nuno Sá <nuno.sa@...log.com>,
 Andy Shevchenko <andy@...nel.org>,
 Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
 linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
 linux-iio@...r.kernel.org
Subject: Re: [PATCH 3/4] regulator: Support the LTM8054 voltage regulator

On Tuesday, 16 September 2025 16:17:56 CEST Romain Gantois wrote:
> Hello Andy,
> 
> On Tuesday, 16 September 2025 15:12:37 CEST Andy Shevchenko wrote:
> > On Tue, Sep 16, 2025 at 12:24:08PM +0200, Romain Gantois wrote:
> > > Add a stub driver for the  Linear Technology LTM8054 Buck-Boost voltage
> > > regulator. This version only supports enabling/disabling the regulator
> > > via
> > > a GPIO, and reporting the output voltage level from the resistor divider
> > > values given in the device tree.
> > 
> > ...
> > 
> > > +#include <linux/module.h>
> > > +#include <linux/of.h>
> > 
> > I think we have already something agnostic in regulator API to get a
> > regulator from a firmware node (rather than from specific OF/etc one).
> 
> IIRC the "of_match" regulator descriptor property can be used for this, I'll
> have a second look and see if I can use that instead.
> 

Looks like I misread your comment sorry, the "of_match" property is pretty 
much irrelevant to using fwnode_* wrappers, and I didn't find any of those in 
the regulator subsystem. I'm missing a Kconfig dependency on "OF" though, I'll 
have to add that.

Thanks,

-- 
Romain Gantois, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)