linux-kernel - Re: [PATCH 0/2] iio: adc: ad7124: drop nr field

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f2eb2424e4b3fc787d1f20b17852e97b1a708cc8.camel@gmail.com>
Date: Thu, 18 Sep 2025 11:25:27 +0100
From: Nuno Sá <noname.nuno@...il.com>
To: David Lechner <dlechner@...libre.com>, Michael Hennerich
	 <Michael.Hennerich@...log.com>, Jonathan Cameron <jic23@...nel.org>, Nuno
 Sá
	 <nuno.sa@...log.com>, Andy Shevchenko <andy@...nel.org>
Cc: linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/2] iio: adc: ad7124: drop nr field

On Wed, 2025-09-17 at 15:39 -0500, David Lechner wrote:
> The motivation behind this series was to remove the `nr` field in struct
> ad7124_channel since it is duplicating the same value as struct
> iio_chan_spec.address (and duplicated again by .scan_index).
> 
> When it came to actually doing that though, I found that it was easier
> to first clean things up by removing the ad7124_enable_channel()
> function - which is a nice cleanup by itself. So ended up with 2 patches
> that end with the same result without ever mentioning the duplication.
> 
> ---
> David Lechner (2):
>       iio: adc: ad7124: inline ad7124_enable_channel()
>       iio: adc: ad7124: remove unused `nr` field
> 
>  drivers/iio/adc/ad7124.c | 19 ++++++-------------
>  1 file changed, 6 insertions(+), 13 deletions(-)
> ---
> base-commit: 561285d048053fec8a3d6d1e3ddc60df11c393a0
> change-id: 20250917-iio-adc-ad7124-drop-nr-field-518102218a61
> 
> Best regards,

Reviewed-by: Nuno Sá <nuno.sa@...log.com>