linux-kernel - Re: [PATCH v3 04/10] mfd: simple-mfd-i2c: add compatible string for LX2160ARDB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <24iulsc4gdozqzs2xrgr4voypltd5gk3bkwsxrlhuo7lymydpq@64t6rppgcfsu>
Date: Thu, 18 Sep 2025 14:28:53 +0300
From: Ioana Ciornei <ioana.ciornei@....com>
To: Lee Jones <lee@...nel.org>
Cc: Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Linus Walleij <linus.walleij@...aro.org>, Bartosz Golaszewski <brgl@...ev.pl>, 
	Shawn Guo <shawnguo@...nel.org>, Michael Walle <mwalle@...nel.org>, devicetree@...r.kernel.org, 
	linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org, Frank Li <Frank.Li@....com>
Subject: Re: [PATCH v3 04/10] mfd: simple-mfd-i2c: add compatible string for
 LX2160ARDB

On Thu, Sep 18, 2025 at 02:15:13PM +0300, Ioana Ciornei wrote:
> On Wed, Sep 17, 2025 at 10:20:06AM +0100, Lee Jones wrote:
> > On Wed, 17 Sep 2025, Ioana Ciornei wrote:
> > 
> > > Extend the list of supported devices with the QIXIS FPGA found on the
> > > LX2160ARDB board.
> > > 
> > > Signed-off-by: Ioana Ciornei <ioana.ciornei@....com>
> > > ---
> > > Changes in v2:
> > > - none
> > > Changes in v3:
> > > - none
> > > 
> > >  drivers/mfd/simple-mfd-i2c.c | 1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/drivers/mfd/simple-mfd-i2c.c b/drivers/mfd/simple-mfd-i2c.c
> > > index 63ac26388860..6fbe85437d8d 100644
> > > --- a/drivers/mfd/simple-mfd-i2c.c
> > > +++ b/drivers/mfd/simple-mfd-i2c.c
> > > @@ -115,6 +115,7 @@ static const struct of_device_id simple_mfd_i2c_of_match[] = {
> > >  	{ .compatible = "maxim,max5970", .data = &maxim_max5970},
> > >  	{ .compatible = "maxim,max5978", .data = &maxim_max5970},
> > >  	{ .compatible = "maxim,max77705-battery", .data = &maxim_mon_max77705},
> > > +	{ .compatible = "fsl,lx2160ardb-fpga" },
> > >  	{ .compatible = "fsl,lx2160aqds-fpga" },
> > >  	{ .compatible = "fsl,ls1028aqds-fpga" },
> > >  	{ .compatible = "spacemit,p1", .data = &spacemit_p1, },
> > 
> > Please keep alphabetical.
> 
> Ok, sure.
> 
> Even without this patch, the fsl compatible strings are not in
> alphabetical order. Are you ok with adding another patch that fixes the
> initial issue or do you want me to just do the changes in a single
> patch?
> 

I just realized that they are not in alphabetical order even when
looking at the other compatible strings other than the fsl ones. I will
add another patch to fix all of them since.