linux-kernel - Re: [PATCH 12/14] drm/imx: dc-lb: Drop initial primary and secondary input selections

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aM13H9AkD6JDalex@lizhi-Precision-Tower-5810>
Date: Fri, 19 Sep 2025 11:30:39 -0400
From: Frank Li <Frank.li@....com>
To: Liu Ying <victor.liu@....com>
Cc: Philipp Zabel <p.zabel@...gutronix.de>,
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
	Maxime Ripard <mripard@...nel.org>,
	Thomas Zimmermann <tzimmermann@...e.de>,
	David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>,
	Dmitry Baryshkov <lumag@...nel.org>,
	dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
	imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 12/14] drm/imx: dc-lb: Drop initial primary and secondary
 input selections

On Fri, Jul 04, 2025 at 05:03:59PM +0800, Liu Ying wrote:
> It's unnecessary to set initial primary and secondary input selections
> because KMS driver would do that when doing atomic commits.  Drop the
> selections.  This is needed as a preparation for reading LayerBlend
> secondary input selection when trying to disable CRTC at boot in an
> upcoming commit.
>
> Signed-off-by: Liu Ying <victor.liu@....com>
> ---
Reviewed-by: Frank Li <Frank.Li@....com>
>  drivers/gpu/drm/imx/dc/dc-lb.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/imx/dc/dc-lb.c b/drivers/gpu/drm/imx/dc/dc-lb.c
> index b0f3fb818799b58597e8ae41d868338c3fd40800..d0a805469ae79d467c7e71ebf75e1befb80e15f3 100644
> --- a/drivers/gpu/drm/imx/dc/dc-lb.c
> +++ b/drivers/gpu/drm/imx/dc/dc-lb.c
> @@ -254,8 +254,6 @@ int dc_lb_get_id(struct dc_lb *lb)
>
>  void dc_lb_init(struct dc_lb *lb)
>  {
> -	dc_lb_pec_dynamic_prim_sel(lb, LINK_ID_NONE);
> -	dc_lb_pec_dynamic_sec_sel(lb, LINK_ID_NONE);
>  	dc_lb_pec_clken(lb, CLKEN_DISABLE);
>  	dc_lb_shdldsel(lb, BOTH);
>  	dc_lb_shdtoksel(lb, BOTH);
>
> --
> 2.34.1
>